Disclaimer: I don't intend to sponsor this package. The following review is
*not* comprehensive:
* Torquil Macdonald Sørensen <torquil@gmail.com>, 2011-08-15, 12:22:
dget -x
http://mentors.debian.net/debian/pool/main/p/python-visvis/python-visvis_1.5-1.dsc
Shouldn't it be "Architecture: all"? I don't see any architecture-specific bits
in the package.
In debian/rules:
| # Uncomment this to turn on verbose mode.
| export DH_VERBOSE=1
Apart from the fact that setting DH_VERBOSE in debian/rules is a feeble idea,
the comment doesn't make sense.
In functions/polarplot.py:
| raise("Array dimensions do not match! %i vs %i " %
| (data1.size, data2.size))
Support for string exceptions has been removed in Python 2.6.
In functions/figure.py:
| # test nr
| try:
| nr = int(nr)
| assert nr > 0
| except (ValueError, AssertionError):
| raise Exception("Figure nr should be an integer >=1")
Err, this is not what assertions are for.
In backends/backend_wx.py:
| try:
| self.ReleaseMouse()
| except:
| pass
"except" without an argument is almost never what you want, because it will
catch, amongst others, KeyboardInterrupt.
pyflakes warns about undefined names:
| ./ssdf.py:1819: undefined name 'name'
| ./backends/backend_wx.py:317: undefined name 'PyAssertionError'
| ./backends/backend_gtk.py:176: undefined name 'glFlush'
| ./wobjects/polygonalModeling.py:43: undefined name 'Error'
| ./vvmovie/images2gif.py:287: undefined name 'pilIm'
| ./vvmovie/images2gif.py:770: undefined name 'out'
| ./vvmovie/images2gif.py:771: undefined name 'out'
| ./vvmovie/images2gif.py:772: undefined name 'out'
| ./core/orientation.py:141: undefined name 'np'
| ./core/orientation.py:148: undefined name 'np'
| ./core/misc.py:315: undefined name 'np'
| ./core/axises.py:1101: undefined name 'tickUnit'
| ./core/axises.py:1365: undefined name 'tickUnit'
| ./core/axises.py:1820: undefined name 'tickUnit'
| ./core/axises.py:1820: undefined name 'lim'
| ./core/axises.py:1919: undefined name 'tickUnit'
| ./core/axises.py:1919: undefined name 'lim'
Please consider joining[0] Debian Python Modules Team and maintaining the
package with us.
[0] http://wiki.debian.org/Teams/PythonModulesTeam/HowToJoin