Hi Jose, On Tue, Aug 02, 2011 at 02:49:41AM +0200, Jose Antonio Quevedo Muñoz wrote: > I am looking for a sponsor for my package "php-benchmark". > http://mentors.debian.net/debian/pool/main/p/php-benchmark/php-benchmark_1.2.8-1.dsc > > I would be glad if someone uploaded this package for me. Thanks for the update! Reviewing your changes I find: 1.) "Merry christmas release"?! Sorry for taking so long to review your package, but still it wasn't *THAT* long. ;-) Moreover you don't need to mention a "maintainer upload" - that's the default. Just like adding the series file if you add a patch. It just won't work without. =) 2.) Your debhelper is quite ancient. Bumping that to newer versions surely doens't hurt. 3.) debian/patches/00-fixpath.diff contains a DEP-3 header but with a lot of template data. Please fill in all fields that make sense and delete the rest next time. 4.) Building your package I see: rm debian/php-benchmark/usr/share/doc/php-benchmark/doc/timer_example.php rm: cannot remove `debian/php-benchmark/usr/share/doc/php-benchmark/doc/timer_example.php': No such file or directory make: [install/php-benchmark] Error 1 (ignored) rmdir debian/php-benchmark/usr/share/doc/php-benchmark/doc rmdir: failed to remove `debian/php-benchmark/usr/share/doc/php-benchmark/doc': No such file or directory make: [install/php-benchmark] Error 1 (ignored) which don't seem to hurt though. 5.) Asking the chatty lintian I see: I: php-benchmark: package-contains-empty-directory usr/share/php/.registry/.channel.doc.php.net/ which may also make sense fixing. 6.) Your Standards-Version is still at 3.9.1. Updating to 3.9.2 would be preferred. 7.) Last but not least I can't upload your package as it no longer has the required files: -rw-r--r-- root/root /usr/share/php/.registry/benchmark.reg -rw-r--r-- root/root /usr/share/php/Benchmark/Iterate.php -rw-r--r-- root/root /usr/share/php/Benchmark/Profiler.php -rw-r--r-- root/root /usr/share/php/Benchmark/Timer.php lrwxrwxrwx root/root /usr/share/php/docs/Benchmark -> ../../doc/php-benchmark have all vanished. Sorry! -- Best regards, Kilian
Attachment:
signature.asc
Description: Digital signature