[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lebiniou, lebiniou-data (3rd try) (new upstream version)

Hash: SHA1

Hi Kilian,

Thanks for reviewing the packages;

On 07/30/2011 12:28 AM, Kilian Krause wrote:
> what's the reason to have:
> 1. dh-autoreconf (none of the patches requires this)

There is a dependency on the "ttf-freefont" package;

The patch "path-to-freemono-font.diff" removes the fonts/ directory from
the build: it modifies configure.ac and the top-level Makefile.am
(and sets the correct path to /usr/share/fonts/truetype/freefont/)

dh-autoreconf is therefore needed, otherwise the package will end up
containing a copy of FreeMono.ttf, and lintian will complain with a:
"W: lebiniou: duplicate-font-file usr/share/lebiniou/fonts/FreeMono.ttf
also in ttf-freefont"

> 2. OSS as default audio driver upstream (and thus Debian patch)

lebiniou also builds on FreeBSD and NetBSD, and for these systems only
OSS is available

> 3. extra -O3 when -O2 is already set as the Debian default?

Some optimizations (eg. -finline-functions, -funswitch-loops,
- -fpredictive-commoning) are set by -O3

> 4. a different lebiniou tarball than the one from your upstream website

The tarballs have possibly gone out-of-sync, I just re-uploaded them.
(the .orig.tar.gz is a symbolic link to the .tar.gz generated by 'make

> Regarding fonts/FreeMono.ttf I'm not sure whether that one needs to be
> removed from the source tarball too.

The previous suggestions I received were to remove it from the tarball
and add a dependency on "ttf-freefont"

> 1. The public domain license is not printed verbatim in debian/copyright.
>    Needs to be added.

The copyright has been set to "Public Domain" and the license to CC0,
included in the 'copyright' file (I hope the text/formating is ok)

> 2. Won't built for me with "pdebuild -- --twice" due to:
> Making all in sequences
> make[2]: Entering directory `/tmp/buildd/lebiniou-data-3.9/sequences'
> ./make-tar.sh
> /bin/bash: ./make-tar.sh: No such file or directory
> make[2]: *** [sequences.tar.gz] Error 127

This is now fixed

> Thanks for your work. Please fix these and ping me when you have updated
> this.

New packages have been uploaded to m.d.n

Thanks again for your time
Best regards,

- --
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/


Reply to: