[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gforth (updated package)

Hi Peter,

On Tue, Jul 12, 2011 at 04:29:14PM +0300, Peter Pentchev wrote:
> I am looking for a sponsor for the new version 0.7.0+ds1-6
> of my package "gforth".  It contains two years' worth of
> packaging fixes along with an attempt at multiarch conversion
> and an acknowledged NMU.  I am asking on the list since
> Patrick Matthäi, who kindly uploaded a couple of previous iterations
> of my adopted gforth packaging, seems to have been busy when I contacted
> him a couple of times during the past year and a half with RFS's.

sorry for taking so long to review your upload even after submitting it to
this list. Now here goes:

> dget http://mentors.debian.net/debian/pool/main/g/gforth/gforth_0.7.0+ds1-6.dsc
> I would be glad if someone uploaded this package for me.  If, in addition,
> the sponsor would be so kind as to set the DMUA flag, I'd be very grateful -
> although, of course, this might not be proper for a first-time sponsoring
> of this particular package.

From what I see you're well up to the job and I see no problem putting it
with one of the next uploads.

Regarding your packaging I'm wondering about:
You explicitly spell out autoconf, automake as Build-Depends yet call dh
only with --with autotools-dev. Why those two on top? Your package seems to build
just fine without them and putting m4 instead.

As this it not a new change it shall not stop me from uploading your package
as is.

Thanks for the work!

Best regards,

Attachment: signature.asc
Description: Digital signature

Reply to: