Re: RFS: winefish

[Elías Alejandro <ealmdz@gmail.com>]

Hi,

On Tue, Jun 28, 2011 at 07:51:14PM -0500, Ruben Molina wrote:
> I'm not a DD, but I had done a short review of your package... 
Also me, here my fast review about your package only to add:

> 
> You need to work in your debian/copyright, because the package's license
> is GPL-2+, and not just GPL, and you are missing lots of entries, e.g.:
> There are many files © by Olivier Sessink, Eugene Morenko, Chris Mazuc,
> Oskar Swida, Pablo De Napoli, or the Winefish Development Team ... 
> You should probably take a look at: http://dep.debian.net/deps/dep5/
> 
> Also, you should clean your debian/rules, all those commented lines can
> be safely removed, and you can probably use some debhelper's tiny rules
> here... Please take a look at /usr/share/doc/debhelper/examples/
 
1. Bump Standards-Version to 3.9.2
2. debhelper is 7. Bump to 8 under: debian/compat, debian/control
3. fail building:
   /usr/bin/install -c -m 644 inline_images/winefish_icon1.png /usr/share/pixmaps/winefish-icon.png
   /usr/bin/install: cannot create regular file `/usr/share/pixmaps/winefish-icon.png': Permission denied
   make[1]: *** [install-icon] Error 1 
   make[1]: Leaving directory `/tmp/buildd/winefish-1.3.3'
   make: *** [install] Error 2
   dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2


Regards,

--
Elías Alejandro