[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

RFS: [QA Upload] netsend



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hello,

I'd like to ask for sponsoring of my QA upload for the package netsed.

It does not introduce a new version since upstream is dead since 2001
but the package is fairly cool, has a reasonable popcon and no open RC
bugs (but WNPP bug #487339[1]. You could adopt it - note there is a
non-official new upstream version you may want to switch to as outlined
in #586037 [2]. Moreover you would eventually becoming upstream as well)

I updated the package and it is in comparatively good shape now - I
believe at least, you may still want to review it however as this is my
first QA upload. I attached a diff outlining all changes I did. This is
in particular:

* I switched to the 3.0/quilt format
* I rewrote the rules file and changed the package to make use of debhelper
* I made some minor corrections in debian/copyright and package description
* I removed all changes in the upstream code (previously the package
changed a version number in upstream's README. I did not found this to
be useful enough to introduce a patch)
* I made some minor tweaks in debian/control, including the Maintainer
field (now QA)
* The package is Lintian clean (but minor pedantic and informational
warnings due to missing upstream stuff, e.g. home page, watch file,
upstream changelog)


The package can be found on mentors.debian.net:
- - URL: http://mentors.debian.net/debian/pool/main/n/netsed
- - Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- - dget
http://mentors.debian.net/debian/pool/main/n/netsed/netsed_0.01c-3.dsc

[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=487339
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=586037

- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJN50LyAAoJEMcrUe6dgPNtXLUP/jj3VpuY97dNetUPIqr4Aiai
tb1vXNvxI0uUNtg6YbmF7BRoBH3pJuSF6rW7n26X8JYSZnODWbj3gAp6RrS9CuaZ
d/xdgumldJLTC7/DjAkyld3y5hiPKUY+3LnTJjGK1nM5eA0Sr9cOjGxBS8Jpe7af
YccEDvV/MSQZC70O1zvesUuNOCmQpnevwc4n0nbviMmdPJDRKHQ/y9i0wm86F2sn
fClTf3MAR/4wG03nC/GmPzHYdvk28CqhvZgYgr1+mtGxBeSBekAqX7cwdg1jZokw
JIEK3tAyY0q4SFYNGdl+cyHv4PT+7RlPMcvlCwawS7nIQXpgDu/Mq8xmWRpO/Ozu
Z/O/b6/7kABU7XfePh38KU0Jr0t1tnPydBHjGLApOOmmyg5SbRoXNvlegh4YIh+a
CEgo6p+SpYVUWLe5k6dGwSyV2HSvixG6xz1aPpUmhn8CqWB9Wxkj4OF6HuZenW6p
RNCy9Pgu9WTRuu/ied0qDH4hYeV+Ziaac8NuGw+3g5qQ5CLVNI42qhgo1UWXyyik
AwOUtE1/erT1mwRcfRUBusQob/VJJzvJA5ncL9LbbbNxbU6a0wl0I89QuULs297e
aTjfafmaaO+JvSEK6XAkKASG6h8kZ7r0AtOO3GbSMEZgczwn8Ky1j7WtHIsD3KoG
njMAfgmMEZmwg/HzPTtI
=iA71
-----END PGP SIGNATURE-----
diff -Nru netsed-0.01c/debian/changelog netsed-0.01c/debian/changelog
--- netsed-0.01c/debian/changelog	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/debian/changelog	2011-06-02 02:44:34.000000000 +0200
@@ -1,3 +1,18 @@
+netsed (0.01c-3) unstable; urgency=low
+
+  * QA upload.
+  * Orphaning package, assign package to the QA team. Maintainer is MIA.
+  * Switch to dpkg-source 3.0 (quilt) format
+  * Start rules file from scratch: use dh 7 mode, make
+    use of various debhelpers (dh_installdocs, dh_installdirs, ...)
+  * Set compat and dependency to debhelper 8
+  * Undo previous modifications of the upstream source. A former maintainer
+    changed a version number in README.
+  * Bump standards, package should comply to all requirements now.
+  * Minor tweaks in debian/copyright
+
+ -- Arno Töll <debian@toell.net>  Thu, 02 Jun 2011 02:17:42 +0200
+
 netsed (0.01c-2.1) unstable; urgency=low
 
   * Non-maintainer upload.
diff -Nru netsed-0.01c/debian/compat netsed-0.01c/debian/compat
--- netsed-0.01c/debian/compat	1970-01-01 01:00:00.000000000 +0100
+++ netsed-0.01c/debian/compat	2011-06-02 01:12:23.000000000 +0200
@@ -0,0 +1 @@
+8
diff -Nru netsed-0.01c/debian/control netsed-0.01c/debian/control
--- netsed-0.01c/debian/control	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/debian/control	2011-06-02 02:14:23.000000000 +0200
@@ -1,26 +1,25 @@
 Source: netsed
 Section: net
 Priority: optional
-Maintainer: Lenart Janos <ocsi@debian.org>
-Standards-Version: 3.5.7.1
+Maintainer: Debian QA Group <packages@qa.debian.org>
+Standards-Version: 3.9.2
+Build-Depends: debhelper (>= 8.0)
 
 Package: netsed
 Architecture: any
-Depends: ${shlibs:Depends}
-Description: The network packet altering stream editor
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: Network packet altering stream editor
  NetSED is small and handful utility designed to alter the contents of
  packets forwarded thru your network in real time. It is really useful
- for network hackers in following applications:
+ for network packet alteration, forging and manipulation. NetSED supports:
  .
    * black-box protocol auditing - whenever there are two or more
      proprietary boxes communicating over undocumented protocol (by
      enforcing  changes in ongoing transmissions, you will be able to
      test if tested application is secure),
- .
    * fuzz-alike experiments, integrity tests - whenever you want to test
      stability of the application and see how it ensures data integrity,
- .
    * other common applications - fooling other people, content filtering,
-     etc etc - choose whatever you want to.
+     and so on - choose whatever suits your requirements.
  .
  It perfectly fits ngrep, netcat and tcpdump tools suite.
diff -Nru netsed-0.01c/debian/copyright netsed-0.01c/debian/copyright
--- netsed-0.01c/debian/copyright	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/debian/copyright	2011-06-02 02:07:02.000000000 +0200
@@ -6,7 +6,7 @@
 
 Upstream Author: Michal Zalewski <lcamtuf@ids.pl>
 
-Copyright:
+Copyright: 2001 Michal Zalewski <lcamtuf@ids.pl>
 
     This package is free software; you can redistribute it and/or
     modify it under the terms of the GNU Lesser General Public
@@ -20,7 +20,9 @@
 
     You should have received a copy of the GNU Lesser General Public
     License along with this package; if not, write to the Free Software
-    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
+    Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, 
+    USA.
+
 
 On Debian GNU/Linux systems, the complete text of the GNU Lesser General
-Public License can be found in `/usr/share/common-licenses/LGPL'.
+Public License can be found in `/usr/share/common-licenses/LGPL-2'.
diff -Nru netsed-0.01c/debian/dirs netsed-0.01c/debian/dirs
--- netsed-0.01c/debian/dirs	1970-01-01 01:00:00.000000000 +0100
+++ netsed-0.01c/debian/dirs	2011-06-02 01:28:25.000000000 +0200
@@ -0,0 +1 @@
+usr/bin/
diff -Nru netsed-0.01c/debian/docs netsed-0.01c/debian/docs
--- netsed-0.01c/debian/docs	1970-01-01 01:00:00.000000000 +0100
+++ netsed-0.01c/debian/docs	2011-06-02 01:31:41.000000000 +0200
@@ -0,0 +1 @@
+README
diff -Nru netsed-0.01c/debian/manpages netsed-0.01c/debian/manpages
--- netsed-0.01c/debian/manpages	1970-01-01 01:00:00.000000000 +0100
+++ netsed-0.01c/debian/manpages	2011-06-02 01:30:29.000000000 +0200
@@ -0,0 +1 @@
+debian/netsed.1
diff -Nru netsed-0.01c/debian/netsed.1 netsed-0.01c/debian/netsed.1
--- netsed-0.01c/debian/netsed.1	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/debian/netsed.1	2011-06-02 02:15:18.000000000 +0200
@@ -47,7 +47,7 @@
 
 This will replace all occurences of \fBpat1\fR with \fBpat2\fR in matching
 packets. Additional parameter (count) can be used to expire rule after 'count'
-succesful substitutions. Eight\-bit characters, including NULL and '/', can
+successful substitutions. Eight\-bit characters, including NULL and '/', can
 be passed using HTTP\-alike hex escape sequences (eg. %0a%0d). Single '%'
 can be reached by using '%%'. Examples:
 .TP
diff -Nru netsed-0.01c/debian/rules netsed-0.01c/debian/rules
--- netsed-0.01c/debian/rules	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/debian/rules	2011-06-02 02:37:33.000000000 +0200
@@ -1,43 +1,18 @@
 #!/usr/bin/make -f
-# debian/rules for netsed by Lenart Janos.
-# Written from scratch.
+# -*- makefile -*-
+
+# debian/rules for netsed by Arno Töll <debian@toell.net>
+# Written from scratch to adapt for debhelper 8
+
+# Uncomment this to turn on verbose mode.
+export DH_VERBOSE=1
 
 pkg = netsed
-checkdir = test -f $(pkg).c -a -f debian/rules
-checkroot = test $$(id -u) = 0
 
-build:
-	$(checkdir)
-	$(MAKE) $(pkg)
-	touch build
-
-clean:
-	$(checkdir)
-	rm -f build
-	-$(MAKE) clean
-	rm -rf debian/tmp debian/files* debian/substvars
-
-binary-indep: build
-
-binary-arch: build
-	$(checkdir)
-	$(checkroot)
-	rm -Rf debian/tmp
-	install -d debian/tmp/DEBIAN
-	install -d debian/tmp/usr/share/doc/$(pkg)
-	install -d debian/tmp/usr/share/man/man1
-	install -d debian/tmp/usr/bin
-	install -m 644 debian/copyright debian/tmp/usr/share/doc/$(pkg)
-	install $(pkg) debian/tmp/usr/bin
-	strip --remove-section=.comment --remove-section=.note debian/tmp/usr/bin/$(pkg)
-	gzip -9c README >debian/tmp/usr/share/doc/$(pkg)/README.gz
-	gzip -9c debian/changelog >debian/tmp/usr/share/doc/$(pkg)/changelog.Debian.gz
-	gzip -9c debian/netsed.1 >debian/tmp/usr/share/man/man1/$(pkg).1.gz
-	dpkg-shlibdeps $(pkg)
-	dpkg-gencontrol -isp
-	chown -R root.root debian/tmp
-	dpkg --build debian/tmp ..
+%:
+	dh $@
 
-binary: binary-indep binary-arch
 
-.PHONY: binary binary-arch binary-indep clean
+override_dh_auto_install:
+	install $(pkg) debian/$(pkg)/usr/bin	
+	
diff -Nru netsed-0.01c/debian/source/format netsed-0.01c/debian/source/format
--- netsed-0.01c/debian/source/format	1970-01-01 01:00:00.000000000 +0100
+++ netsed-0.01c/debian/source/format	2011-06-02 01:00:58.000000000 +0200
@@ -0,0 +1 @@
+3.0 (quilt)
diff -Nru netsed-0.01c/README netsed-0.01c/README
--- netsed-0.01c/README	2011-06-02 02:45:23.000000000 +0200
+++ netsed-0.01c/README	2001-01-08 17:02:17.000000000 +0100
@@ -1,5 +1,5 @@
 
-  netsed 0.01c                          (C) Michal Zalewski <lcamtuf@ids.pl>
+  netsed 0.01b                          (C) Michal Zalewski <lcamtuf@ids.pl>
   --------------------------------------------------------------------------
 
   "When things go well, expect something to explode, erode, collapse or



Reply to: