[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Fwd] Bug#621966: hasciicam: FTBFS: hasciicam.c



On Tuesday 26 April 2011 17:14:24 Jaromil wrote:
On Tue, 26 Apr 2011, George Danchev wrote:
> I had a look at it since it is a relatively simple package one can
> quickly learn to grasp and you fix a FTBFS, though the diff compared
> to what we have in sid is rather large.

you mean lots changed? well, if you have a look at the frequency of
updates in the past... i've spent 3 or 4 years hearing from people how
hasciicam wouldn't work on debian and asking them to compile from
source to fix... and this is not just the situation of my package.

to make it really clear let me specify that i'm not bashing Lucas for
filing a bug here, nor the maintainers of hasciicam for giving it a
very low priority: i'm trying to give an account "from below" on how
things look to an upstream author.

Maybe it is about time to be part of the solution.

> I also tested it to the extend 'works for me'. Few pointers:
>
> 1) upstream ChangeLog is meager.
> (new header videodev2.h used ... at least?)

ok, i'll repair that in the future, i needs some time to reconstruct
that history.

Good.

> 2) debian/changelog does not close the proper bug.
> you can close the manually, but still.

should we edit a past entry now?
it was fixed in 1.1.1 so i'd rather close it by hand.

I added 'closes' in 1.1.1 entry, and built it so that
the last two changelog entries will show up in *.changes.
BTW will do the rest for us. This way the changelog alone
is also descriptive wrt that bug.

> 3) debian/copyright lacks the copyright holders of
> of ftplib.[h|c]
>
> 4) you don't use ftplib already available in Debian, but
> embed an outdated copy of it instead. Headers seem identical,

ack! thanks for noticing.

i've made a new upstream release and package: both remove ftplib from
inside the hasciicam code and link it from shared library.
Build-Deps reflect this change.


http://apt.dyne.org/debian/pool/main/h/hasciicam/hasciicam_1.1.2-1.dsc

upstream release: http://ftp.dyne.org/hasciicam/releases

Uploaded. Thanks for taking care of that FTBFS, but
I'd still suggest you reconsider the DM/DD links.

thanks for the review!

Welcome.

--
pub 4096R/0E4BD0AB <people.fccf.net/danchev/key pgp.mit.edu>


Reply to: