On Mon, Mar 28, 2011 at 01:27:04AM +0800, Chow Loong Jin wrote: > Dear mentors, > > I am looking for a sponsor for the new version 0.3.2-1 > of my package "alarm-clock-applet". > > It builds these binary packages: > alarm-clock-applet - Alarm Clock applet > > The package appears to be lintian clean. > > The package can be found on mentors.debian.net: > - URL: http://mentors.debian.net/debian/pool/main/a/alarm-clock-applet > - Source repository: deb-src http://mentors.debian.net/debian unstable main > contrib non-free > - dget > http://mentors.debian.net/debian/pool/main/a/alarm-clock-applet/alarm-clock-applet_0.3.2-1.dsc > - git clone git://git.debian.org/git/collab-maint/alarm-clock-applet.git > > I would be glad if someone uploaded this package for me. Hi, Bearing in mind that I'm not a DD yet and cannot really help you by uploading the package, what do you think about the attached four patches that IMHO might improve the packaging a bit further? - get the CPPFLAGS, CFLAGS and LDFLAGS variables from the dpkg-buildflags tool introduced in dpkg-dev 1.15.7 - properly pass --watchfile and not --watchfie to uscan ;) - no need to pass the changelog name to dh_installchangelogs since 7.0 - bump the debhelper compatibility level to 8 with no further changes Of course, it's your package, it's your call whether to accept them or not. Thanks for making Debian better by taking care of its packages! G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org peter@packetscale.com PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 I am not the subject of this sentence.
From cece1ba34d12413421bcefa54997940ce52b33b3 Mon Sep 17 00:00:00 2001
From: Peter Pentchev <roam@ringlet.net>
Date: Mon, 28 Mar 2011 15:54:07 +0300
Subject: [PATCH 1/4] Get CPPFLAGS, CFLAGS and LDFLAGS from dpkg-buildflags.
---
debian/control | 1 +
debian/rules | 8 +++++++-
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/debian/control b/debian/control
index de21784..f655f7e 100644
--- a/debian/control
+++ b/debian/control
@@ -5,6 +5,7 @@ Maintainer: Chow Loong Jin <hyperair@ubuntu.com>
Uploaders: Johannes H. Jensen <joh@pseudoberries.com>
Build-Depends: debhelper (>= 7.0.50),
autotools-dev,
+ dpkg-dev (>= 1.15.7~),
intltool (>= 0.40),
libglib2.0-dev (>= 2.16.0),
libgtk2.0-dev (>= 2.12.0),
diff --git a/debian/rules b/debian/rules
index 6649275..bddfc3a 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,7 +1,13 @@
#!/usr/bin/make -f
# -*- makefile -*-
-export LDFLAGS=-Wl,--as-needed -Wl,-z,defs
+CFLAGS:= $(shell dpkg-buildflags --get CFLAGS)
+CPPFLAGS:= $(shell dpkg-buildflags --get CPPFLAGS)
+LDFLAGS:= $(shell dpkg-buildflags --get LDFLAGS)
+
+LDFLAGS+= -Wl,--as-needed -Wl,-z,defs
+
+export CPPFLAGS CFLAGS LDFLAGS
MAKEFILE = $(firstword $(MAKEFILE_LIST))
DEBIAN_DIR = $(dir $(MAKEFILE))
--
1.7.4.1
From f13274b1ed9061aeb37a316765b35d4bcbbab690 Mon Sep 17 00:00:00 2001 From: Peter Pentchev <roam@ringlet.net> Date: Mon, 28 Mar 2011 15:54:55 +0300 Subject: [PATCH 2/4] Fix a typo in the get-orig-source target. --- debian/rules | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/debian/rules b/debian/rules index bddfc3a..0da88dc 100755 --- a/debian/rules +++ b/debian/rules @@ -23,7 +23,7 @@ get-orig-source: --rename \ --package=$(PACKAGE) \ --upstream-version=$(VERSION) \ - --watchfie=$(DEBIAN_DIR)/watch \ + --watchfile=$(DEBIAN_DIR)/watch \ --destdir=. # disable tests; it requires a running D-Bus session -- 1.7.4.1
From b5824e589a535d23c5dc8a093f31f0b51ab14fb3 Mon Sep 17 00:00:00 2001 From: Peter Pentchev <roam@ringlet.net> Date: Mon, 28 Mar 2011 15:56:46 +0300 Subject: [PATCH 3/4] dh_installchangelogs knows about ChangeLog now. --- debian/rules | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/debian/rules b/debian/rules index 0da88dc..fc48232 100755 --- a/debian/rules +++ b/debian/rules @@ -29,9 +29,6 @@ get-orig-source: # disable tests; it requires a running D-Bus session override_dh_auto_test: -override_dh_installchangelogs: - dh_installchangelogs ChangeLog - clean: dh $@ %: -- 1.7.4.1
From c05e35091d76a4e73f50538d7283d23b3cb4a7ae Mon Sep 17 00:00:00 2001
From: Peter Pentchev <roam@ringlet.net>
Date: Mon, 28 Mar 2011 17:03:41 +0300
Subject: [PATCH 4/4] Bump the debhelper compat level to 8 with no further changes.
---
debian/compat | 2 +-
debian/control | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/compat b/debian/compat
index 7f8f011..45a4fb7 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@
-7
+8
diff --git a/debian/control b/debian/control
index f655f7e..416927f 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: gnome
Priority: optional
Maintainer: Chow Loong Jin <hyperair@ubuntu.com>
Uploaders: Johannes H. Jensen <joh@pseudoberries.com>
-Build-Depends: debhelper (>= 7.0.50),
+Build-Depends: debhelper (>= 8),
autotools-dev,
dpkg-dev (>= 1.15.7~),
intltool (>= 0.40),
--
1.7.4.1
Attachment:
signature.asc
Description: Digital signature