[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: gpy - updated

Hi Gryllida,

G... wrote:
> A newer version is now available, URL for any of them is
> http://mentors.debian.net/debian/pool/main/g/gpy/ , please use that
> for review for reviewing from now on.

Just a few comments:

 - debian/changelog is rather cryptic. What happened to earlier entries?
   See [1] for information about how to write a good changelog.
   Also, it doesn't close any bugs.

   [1] http://www.debian.org/doc/developers-reference/best-pkging-practices.html#bpp-debian-changelog

 - debian/patches/debian-changes-0.3.6-4 is patching the upstream
   changelog and creating a file in an upstream directory; I don't think
   that it's what you want to do. Since you're upstream, you should
   include additional files directly upstream (or if for some reason you
   really don't want to, put the file somewhere in debian/ and include
   it from there). And in any case, you shouldn't touch the upstream
   changelog from the debian packaging.

 - debian/docs is empty, you should remove it. And debian/gpy.manpages
   doesn't do anything, you should remove it too (and you may want to
   include docs/gpy.1 in debian/gpy-start.manpages).

 - You should consider following DEP5 [2] for debian/copyright.

   [2] http://dep.debian.net/deps/dep5/

I hope this helps.


Benoît Knecht

Reply to: