Re: RFS: ulatencyd - Daemon to minimize latency on a linux system using cgroups (2nd try)
- To: firstname.lastname@example.org
- Subject: Re: RFS: ulatencyd - Daemon to minimize latency on a linux system using cgroups (2nd try)
- From: Didier 'OdyX' Raboud <email@example.com>
- Date: Wed, 02 Mar 2011 17:35:04 +0100
- Message-id: <firstname.lastname@example.org>
- References: <20110227171926.GA16294@PC-Ale>
Alessandro Ghedini wrote:
> Dear mentors,
> I am looking for a sponsor for my package "ulatencyd".
here is my (promised) review, with some delay; please forgive me for that;
life took over…
> ulatencyd - Daemon to minimize latency on a linux system using cgroups
> The package appears to be lintian clean.
> The upload would fix these bugs: 610495 (ITP)
Now some questions:
* Why don't you ship the systemd service file? With systemd around the
corner, you will certainly end up adding it in the future. And why are you
stripping it away with a patch (where you could dh_auto_install to
debian/tmp and have a "ulatencyd.install" file to opt files _in_) ? I would
just correct the path in this install file and be done with it.
* Your debian/init.d isn't named correctly (IMHO). man dh_installinit tells
us that it should be named debian/ulatency.init (or debian/init, but I very
much prefer being explicit). As for the names, it's the same for logrotate,
manpages and docs (but don't worry, it's mostly a matter of taste).
* Deactivation of the tests: why do you disable the tests ? Build tests
should be run and they should not fail (obviously…). You should either
comment your debian/rules explaining the reasons or (preferably) convince
upstream to patch (or patch yourself) the tests in order to be able to run
within the buildd environment.
* debian/gbp.conf should not be in the source package; having a
debian/source/local-options to filter it out sounds nice.
Otherwise it sounds nice.