[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: liboauth (Updated package)

Hi Ansgar,

On 02/07/2011 08:35 PM, Ansgar Burchardt wrote:
> Hi,
> Bilal Akhtar <bilalakhtar@ubuntu.com> writes:
>>> I noticed you patched src/xmalloc.c to not exit in xmalloc_fatal.  Does
>>> the rest of the code handle this change correctly?
>> Yes it does. This change has been around for more than a month in Debian
>> experimental and Ubuntu natty, and through some tests I found no
>> problems with it so far.
> Did you ever run into an out of memory condition where the modified
> xmalloc_fatal is called?

I never tried to run that explicitly. All I did was to test out whether
all the oauth_* library functions were working well.

Thanks a lot for finding out the bug. I request you to file it in the
BTS so that I could work on it for the next upload.

I will inform the upstream dev about this one, and will work with him
for this change.

Thanks again,

Bilal Akhtar.

> I did "sabotage" xmalloc to always call xmalloc_fatal using the attached
> patch. With this the test suite failed with a segmentation fault. So it
> seems the upstream code does *not* handle xmalloc_fatal returning
> correctly:
> --8<---------------cut here---------------start------------->8---
> make  check-TESTS
> make[3]: Entering directory `/build/sbuild-liboauth_0.9.4-1.1-amd64-mIm2gv/liboauth-0.9.4'
> Out of memory./bin/bash: line 5: 23730 Segmentation fault      ${dir}$tst
> FAIL: tests/tcwiki
> Out of memory./bin/bash: line 5: 23754 Segmentation fault      ${dir}$tst
> FAIL: tests/tceran
> Out of memory./bin/bash: line 5: 23778 Segmentation fault      ${dir}$tst
> FAIL: tests/tcother
> ========================================
> 3 of 3 tests failed
> --8<---------------cut here---------------end--------------->8---
> Regards,
> Ansgar

Bilal Akhtar - Ubuntu Developer <bilalakhtar@ubuntu.com>
IRC nick: cdbs

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: