[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: lilo (updated package)



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 2011-01-19 20:51, Joachim Wiedorn wrote:
> Dear mentors,
> 

Hey

> I am looking for a sponsor for the new version 1:23.1-1 of my package
> "lilo".
> 
> It builds these binary packages:
> lilo       - LInux LOader - the classic OS boot loader
> lilo-doc   - LInux LOader - Documentation for the classic OS boot loader
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 158955, 244741, 278373, 287257, 304065,
> 306472, 325235, 335084, 339778, 389328, 409663, 428390, 431077, 459714,
> 504267, 522283, 590022, 596258, 599934
> 
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/lilo
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> - dget http://mentors.debian.net/debian/pool/main/l/lilo/lilo_23.1-1.dsc
> 
> I would be glad if someone uploaded this package for me.
> 
> Some notes: 
> - This package goes into unstable, ready for squeeze+1.

Right, but until Squeeze is out I will upload to unstable without prior
agreement with the release team.

> - This package can be build an Ubuntu systems, too (without changes).
> 
> Kind regards
>  Joachim Wiedorn
> 
> 
> ---
> Here is the changelog of these package:
> 
> 
> lilo (1:23.1-1) unstable; urgency=low
> 
>   * New upstream release. (Closes: #339778)
>   * Upstream bugfixes:
>     - Option 'append' works with acpi=off. (Closes: #428390)
>     - Working on degraded RAID-1 device. (Closes: #278373, #522283)
>     - Working with spaces in labels. (Closes: #287257)
>     - Using new hook scripts for kernel and initrd only one time
>       when needed. (Closes: #599934)
>     - Include diffs for NMUs. (Closes: #504267, #409663)
>     - Fix error with LVM partition. (Closes: #244741)
>     - Compatible with devmapper version. (Closes: #325235)
>   * Solved upstream bugs of Ubuntu:
>     - Raid related error while upgrading (LP: #242879)
>     - Warn if initrd is too large (LP: #260059)
>     - Allow using LVM as root partition (LP: #274972)
>     - Stack overlaping on second stage (LP: #438177)
>     - Raid setup fatal errors (LP: #470502)
>     - Use hook scripts while updating kernel/initrd 
>       (LP: #43869, #345482, #628858, #636211, #691975)
> 
>   * Remove all old patches.
>   * Remove very old lilo.conf examples.
>   * Remove obsolete file debian/NEWS.
>   * Bump to Standards Version 3.9.1.
>   * Move to debhelper compatibility level 7.
>   * Move to source format 3.0 (quilt).
>   * Update and new formatting of debian/copyright.
>   * debian/control:
>     - Move source dependency debhelper to version >= 7.0.15.
>     - Update some versions of source dependencies and remove quilt.
>     - Add VCS urls in Alioth.
>     - Add in package lilo-doc dependency to lilo.
>     - Optimize package descriptions.
> 
>   * Update all debian/lilo.* and debian/lilo-doc.* files.
>   * Add new debian/lilo-doc.doc-base file.
>   * Remove lilo.sh wrapper script, used because of devfsd.
>   * Remove obsolete script lilo_find_mbr and its manpage.
>   * Remove configured link update-lilo to liloconfig.
>   * Remove some obsolete manpages.
>   * Move script liloconfig into directory debian/scripts.
>   * Add new script update-lilo and its manual page. (Closes: #335084)
>   * Add new script lilo-uuid-diskid for ID conversion and its manual page.
> 
>   * Update scripts lilo.postinst, lilo.postrm, lilo.preinst.
>   * Add link creation for menu background sarge.bmp and sid.bmp
>       for compatibility in file debian/lilo.postinst.
>   * Remove hook scripts for kernel and initramfs and use upstream scripts.
>       (Closes: #590022, #306472, #389328)
>   * debian/patches:
>     - Add new patches for Debian.
>     - Add patches for simple rules using dh 7.
>   * debian/rules:
>     - Use simple rules with dh 7 capabilities.
>   * Move debian/Makefile.floppy into debian/floppy directory
>       and fix this Makefile. (Closes: #158955)
>   * Add debian/lilo.install file.
>   * Add lintian-overrides for package lilo.
>   * Update debian/README.Debian file.
>   * Remove obsolete file debian/NEWS.
>   * Remove obsolete debian/TODO file.
>   * Remove obsolete debian/lilo.changelogs file.
>   * Add patchset and changelog entries for use in Ubuntu.
> 
>   * debconf files:
>     - Remove message above old bitmap path. (Closes: #304065)
>     - Update of debian/lilo.templates and debian/lilo.config.
>     - Add some code to these files using lilo-uuid-diskid.
>     - Small update of german translation.
>     - Add updated Danish debconf translation. (Closes: #596258)
> 
>   * Some more bugfixes:
>     - Add usage hints about -H option in src/lilo.c. (Closes: #459714)
>     - su-to-root command without path in debian/lilo.menu. (Closes:
>     #431077)
>     - Diffs for NMUs already included. (Closes: #504267, #409663)
>     - Remove old obsolete workaround (see bugreport 146350#25).
> 
>  -- Joachim Wiedorn <ad_debian@joonet.de>  Tue, 18 Jan 2011 23:38:32 +0100
> 
> 

lilo-23.1/debian/lilo.postinst:
+       # remove scripts of old lilo 22.8 if still exist
+       if test -f /etc/kernel/postinst.d/zz-lilo; then
+               rm -f /etc/kernel/postinst.d/zz-lilo; fi
+       if test -f /etc/kernel/postrm.d/zz-lilo; then
+               rm -f /etc/kernel/postrm.d/zz-lilo; fi
+       if test -f /etc/initramfs/post-update.d/lilo; then
+               rm -f /etc/initramfs/post-update.d/lilo; fi


You cannot remove them if they have been modified by the local system
administrator.  Policy Manual 10.7.3 (emphasis added by me):

""
Configuration file handling must conform to the following behavior:

 * local changes *must* be preserved during a package upgrade, and

 * configuration files must be preserved when the package is removed,
   and only deleted when the package is purged.

Obsolete configuration files without local changes /may/ be removed by
the package during upgrade. ""

 - That being said you can move them out of the way.

I suggest you read http://wiki.debian.org/DpkgConffileHandling for how
to do it properly.  If you use the dpkg tool then it will be a
Pre-Depends on dpkg >= 1.15.7.2 (since you need to add code in preinst
as I recall).  I am a little hazy on the details.



debian/patches/02_lilo-version-${vendor}.patch:
  - Looks like lilo could use a "branding" macro or so for the build.
  - Any reason you replaced the "GNU/Linux" part with Debian in
    src/crt.S? Considering that Lilo is only supported on x86 and amd64
    for Linux, "Debian GNU/Linux" is still quite valid (or will lilo
    also work for the FreeBSD ports?).

debian/patches/03_keytab-lilo.8-${vendor}.patch:
  - It looks like the doc is being installed in lilo-doc instead of
    lilo though.
  - Since Ubuntu is based on Debian you can merge this into one patch.
    You can choose to use "Debian-based" if you prefer that.

debian/patches/04_lilo.8-for-${vendor}.patch:
  - The "lilo vs lilo-doc" applies here as well.


You can merge (most of)? the ${vendor} patches into a single patch and
just used "Debian" or "Debian-based Systems" if you want to reduce the
amount of patches.

doc/README:
  - Says distclean will remove "pre-built LaTex files"...

But I cannot see any part of doc/Makefile actually delete any .fig
files.  A quick look at d/rules suggest it does not remove it either, so
are these rebuilt from source?

... and now it is way past 2 am. >.>

~Niels
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBCAAGBQJNOjlFAAoJEAVLu599gGRCbdAP/3CP5+TyFzQDntvIGPsrrFu4
U2MDqwJtNpYV6Y91Bj9FOaSOZYhWxmepOh+d6p1puJkiHhqnow+3xHPASoY7Fkhe
TNbyMEQfwtnPmaTTbIbJpIyY3mWI6VDoDdFQXYcCDRS7+1+oEFt/JF4JBp8zptRe
wp0++Nbr2yT2IPHxlsSFrkL63JjGhYcfTvmUSd9CuNlszxZw/xr6TcPZY/n32kbX
xLQlvdEPbxbPTBUZZAmjGjtT4oyqBj32vQmMXB2oNK+6SRxaCqI6aUc/ja8No1d0
l6oOljiT87dgu3sonfJESYUba7AcFwWhe/2rcutwWqv5we0VRjgjsawEm9H6UivQ
k/Yg8cpvTA+8ZkEmltM4UMr4t+ZzflqihLO6DAv12kyRLIHzMpp9XUwC7FDhmyBM
BXNNG4oyN1F3JUG+rVZVXXIiDHJpRuc53A3t2305iUNt4NiAgs3Kyh0uVSJwiPCh
YYjYgk26VlB5/ebhHIyoTnG3/Q74vO74EEpl2U3RYyQLLxFM5nFm94HruJD/jyHZ
S7OlXb3ePwF9SoOMjkSvsNWvYEqhZuPKFRS4R49/zaqHglwOEyWQoC41UTS4Alka
5S+f69RLVywdsl/3ZsQJXu9PJQKxiMGLqa2lYvKztqabP33DiKttHUZFnGbIXx/j
Qq4BOX+5zhUBDuDWwdhV
=E1Sh
-----END PGP SIGNATURE-----


Reply to: