Ali,I'm not a mentor, but I believe that your questions can be answered by entire reading this article: http://people.debian.org/~codehelp/Best regards,@Fernando MercêsLinux Registered User #432779------------------------------------------------------------------------------Participe do I Hack'n Rio, dias 8 e 9 de abril na UFRJ!------------------------------------------------------------------------------
On Sun, Jan 16, 2011 at 11:01 PM, mezgani ali <handrix@gmail.com> wrote:Hi Jonathan,
I thank you first for your suggestions, well i fixed most of them and here i have some questionsOn Mon, Jan 17, 2011 at 12:05 AM, Jonathan Wiltshire <jmw@debian.org> wrote:
Hi,
I'm not in a position to sponsor your package, but I started reviewing it
and found several problems:
This isn't a suitable short description, and the long description gives no
On Sun, Jan 16, 2011 at 09:08:28PM +0000, mezgani ali wrote:
> I am looking for a sponsor for my package "aescrypt".
>
> * Package name : aescrypt
> Version : 3.05-1
> Upstream Author : Glenn Washburn <crass@berlios.de>, Paul E.
> Jones <paulej@packetizer.com>, Mauro Gilardi <galvao.m@gmail.com>
> * URL : http://www.aescrypt.com/
> * License : gpl
> Section : utils
>
> It builds these binary packages:
> aescrypt - Using a powerful 256-bit encryption algorithm,
indication why I would want to use it. See the developer's reference for
short description tips.
I doubt this, but I couldn't even build it to check:
> The package appears to be lintian clean.
| make[1]: Entering directory `/tmp/aescrypt-3.05'
| gcc -Wall -D_FILE_OFFSET_BITS=64 -c aescrypt.c
| gcc -Wall -D_FILE_OFFSET_BITS=64 -c aes.c
| gcc -Wall -D_FILE_OFFSET_BITS=64 -c sha256.c
| gcc -Wall -D_FILE_OFFSET_BITS=64 -c password.c
| gcc -Wall -D_FILE_OFFSET_BITS=64 -o aescrypt aescrypt.o aes.o sha256.o password.o
| install -o root -g root -m 755 aescrypt /usr/bin
| install: cannot create regular file `/usr/bin/aescrypt': Permission denied
| make[1]: *** [install] Error 1
That implies that you've been building as root - the autobuild network
doesn't, so you need to check for this. You should also use 'dpkg -c *.deb'
to check the package contains the files you expect; in this case, it
wouldn't have had the binary in.
The watch file also fails:
May a package contain obligatory a watch file ?
|-- Found watchfile in ./debian
|-- In debian/watch, processing watchfile line:
| http://www.aescrypt.com/cgi-bin/download?file=v3/aescrypt(.*)_source\.tar\.gz
| uscan debug: requesting URL http://www.aescrypt.com/cgi-bin/download?file=v3/
<snip>
| uscan warning: In debian/watch,
| no matching hrefs for watch line
| http://www.aescrypt.com/cgi-bin/download?file=v3/aescrypt(.*)_source\.tar\.gz
There's some trailing whitespace in debian/control, and as above you need
to improve the short and long descriptions.
Fixed
The source files that have license grants at the top mention GPL2+, not
GPL3+ as in your copyright file.
Fixed
The clean target does not remove debian/aescrypt.debhelper.log, so that
file got included in your diff. The file debian/files is empty, get rid of
it.
Fixed
README.Debian and README.source are also useless. A user looking in
/usr/share/doc/aescrypt for those files will see Readme.txt right alongside
them, so remove the extra step and leave it at that.
May i remove them or maybe append the content of Readme.txt filedebian/rules includes lots of unneccessary calls and some lines are just
commented out, so they can be removed to make it easier to read. It looks
like it's just been copied from echoping:
Fixed# Add here commands to install the package into debian/echoping.
You can't pass DESTDIR into the upstream make file, because it never uses
it - you'll have to persuade upstream to fix the makefile or patch it not
to install files to /usr/bin. From the look of your debian/rules, you can
probably use the small or tiny form for debhelper, which gets rid of almost
all the clutter.
After fixing the build system lintian has these pointers:
I: aescrypt: extended-description-is-probably-too-short
W: aescrypt: binary-without-manpage usr/bin/aescryptP: aescrypt: no-upstream-changelog
E: aescrypt: debian-changelog-file-missing
E: aescrypt: unstripped-binary-or-object ./usr/bin/aescrypt
The last three are because of missing debhelper calls, they should be easily
fixed.
--
Jonathan Wiltshire jmw@debian.org
Debian Developer http://people.debian.org/~jmw
4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC 74C3 5394 479D D352 4C51
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iQIcBAEBAgAGBQJNM4fAAAoJEFOUR53TUkxROSUP/1dKuygF0/2r4bZP6quBMElq
+q4k8c2KxgmDhFvy99EyO11Go2H+mg5kdnYIUcc+ZnNYmEjCzbxbWeUaFdLoFa0b
uHVY1lslbt1Eq6fTAft0TuXc3kmwCNIquRKxC8G+vK3KD4oofgZ/H7RkhCGwJ2gJ
A/XW9X8fhcdmnf/dDHXFJcIVGkzz8CgI+N8ghvkRJYX9kbYENQpvyNfutFx5tsH4
QeunRqFv1QCtObZ5HhH4eMcZIjT0qT/HFgXrwjsjQR95UkdkEzUiqNKs3uQGwMJe
QtATS82VVUJJMlF6lyhybFQtkkMDx9vIgpks/ACQNVFdMEjNVORYIO/L1QdW2Xds
5jsnEPvkJTONJAvnd/V197lm6O7t4ytAu7fXws8A78aiXbwL/82z6OF4temnaF9n
oP4KqB/BJgC11N4oHlx0lxGYRhorWXd+Xff0qiV3BPZ/lsyryefsWDzIXBaadZ2y
E7gpXk1It/AgqXAEm8nSCHdol2pjV490BpQVro9VVCsS2gMpYZeGMuNOzvfOIfjH
LJxQ47QX215tbQqJ7HiFl8BPVOWvREPpILuGAWtvC2z0dS8PS/j+iahvO4ecwLLG
QfkW/3V5giltHEGq22017rqqTjZ2rpxO9yHOTj2yJ+bDmU5d06BQQ6D8xV4l9yfX
ElLQ3dmy5D5eey/dGMnH
=+Zrr
-----END PGP SIGNATURE-----
--
Ali MEZGANI
Network Engineering/Security
http://securfox.wordpress.com/