Hi Julien On Mon, Dec 27, 2010 at 08:45:22AM +0100, Julien Palard wrote: > On Sun, Dec 26, 2010 at 1:42 PM, Salvatore Bonaccorso <carnil@debian.org> wrote: > > I had now time to review the package, sorry for the log delay! > > Don't worry for this ! > > > - debian/copyright: missing space inbetween first stanza and first > > Files: stanza. > > Done Good! > > - debian/watch: > > --> v0.1 != 0.1 ... Either change the experession to v(.*) .... so > > Done by renaming the tag Ok this is fine. See just below for further comment. > > Question: is it possible to release upstream's source tar.gz as logtop-$version.tar.gz? > > So logtop-0.1.tar.gz ? as done here ? I was wondering if you could release it as logtop-$version.tar.gz upstream, instead of $version.tar.gz. Because if someone then downloads upstreams tar.gz with uscan, it is simply downloaded as 0.1.tar.gz. Usually you have the source name too in the tarball. Anyway I noticed the following problem: 08fbc68b118bea6321195b8645ea7643 0.1.tar.gz 3f46c68085940aa7c82191103faec37d logtop_0.1.orig.tar.gz I checked then the content: tar tzvf 0.1.tar.gz drwxrwxr-x root/root 0 2010-12-12 20:57 JulienPalard-logtop-dee72e6/ -rw-rw-r-- root/root 1331 2010-12-12 20:57 JulienPalard-logtop-dee72e6/COPYRIGHT -rw-rw-r-- root/root 662 2010-12-12 20:57 JulienPalard-logtop-dee72e6/Makefile -rw-rw-r-- root/root 3205 2010-12-12 20:57 JulienPalard-logtop-dee72e6/NCURSES_COPYRIGHT -rw-rw-r-- root/root 1360 2010-12-12 20:57 JulienPalard-logtop-dee72e6/README drwxrwxr-x root/root 0 2010-12-12 20:57 JulienPalard-logtop-dee72e6/doc/ -rw-rw-r-- root/root 2084 2010-12-12 20:57 JulienPalard-logtop-dee72e6/doc/logtop.1 drwxrwxr-x root/root 0 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/ -rw-rw-r-- root/root 3867 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/avl.c -rw-rw-r-- root/root 3491 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/curses.c -rw-rw-r-- root/root 4737 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/logtop.c -rw-rw-r-- root/root 2566 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/logtop.h -rw-rw-r-- root/root 2845 2010-12-12 20:57 JulienPalard-logtop-dee72e6/src/stdout.c and tar tzvf logtop_0.1.orig.tar.gz drwxr-xr-x mandark/mandark 0 2010-12-27 08:37 logtop-0.1/ -rw-r--r-- mandark/mandark 1360 2010-12-14 20:47 logtop-0.1/README -rw-r--r-- mandark/mandark 3205 2010-11-13 16:36 logtop-0.1/NCURSES_COPYRIGHT drwxr-xr-x mandark/mandark 0 2010-12-20 19:41 logtop-0.1/.pc/ -rw-r--r-- mandark/mandark 7 2010-12-14 23:11 logtop-0.1/.pc/.quilt_series -rw-r--r-- mandark/mandark 2 2010-12-14 23:11 logtop-0.1/.pc/.version -rw-r--r-- mandark/mandark 0 2010-12-20 19:41 logtop-0.1/.pc/applied-patches -rw-r--r-- mandark/mandark 15 2010-12-14 23:11 logtop-0.1/.pc/.quilt_patches drwxr-xr-x mandark/mandark 0 2010-12-27 08:31 logtop-0.1/doc/ -rw-r--r-- mandark/mandark 1839 2010-12-27 08:36 logtop-0.1/doc/logtop.1 -rw-r--r-- mandark/mandark 1331 2010-11-13 16:36 logtop-0.1/COPYRIGHT drwxr-xr-x mandark/mandark 0 2010-12-27 08:37 logtop-0.1/src/ -rw-r--r-- mandark/mandark 4737 2010-12-14 20:47 logtop-0.1/src/logtop.c -rw-r--r-- mandark/mandark 3491 2010-12-12 00:17 logtop-0.1/src/curses.c -rw-r--r-- mandark/mandark 2845 2010-12-05 20:09 logtop-0.1/src/stdout.c -rw-r--r-- mandark/mandark 3867 2010-12-05 20:09 logtop-0.1/src/avl.c -rw-r--r-- mandark/mandark 2566 2010-12-03 09:57 logtop-0.1/src/logtop.h -rw-r--r-- mandark/mandark 4065 2010-12-17 16:09 logtop-0.1/CHANGELOG -rw-r--r-- mandark/mandark 662 2010-12-15 08:19 logtop-0.1/Makefile So it seems, did you added the CHANGELOG afterwards to upstream's tarball? And there are also the .pc directories which should not be therein. Suggestion: Release upstream a new version adding the CHANGELOG file now, and release it with updated version. > > - lintian: > Checked with --pedantic ! This is not 'enough', because it does not add then the other checks too. I always use somethin like: lintian --pedantic -v -iI --display-experimental --show-overrides --checksums --color auto Bests Salvatore
Attachment:
signature.asc
Description: Digital signature