[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: triggerhappy



Dies schrieb Niels Thykier (niels@thykier.net):

> >> Checking cmdsocket.c...
> >> [cmdsocket.c:126]: (error) Resource leak: fd
[...]
> Okay, perhaps you could document this in the code that this is
> intentional (e.g. transmitting the fd and the leak is a false-positive)?

I'm playing around with cppcheck myself, but I cannot reproduce the message above;
how did you call the program?
stefan@exa:~/git/triggerhappy$ cppcheck . --enable=all -v
Checking ./cmdsocket.c...
1/11 files checked 9% done
Checking ./devices.c...
2/11 files checked 18% done
Checking ./eventnames.c...
3/11 files checked 27% done
Checking ./ignore.c...
4/11 files checked 36% done
Checking ./keystate.c...
5/11 files checked 45% done
Checking ./obey.c...
6/11 files checked 54% done
Checking ./th-cmd.c...
7/11 files checked 63% done
Checking ./thd.c...
8/11 files checked 72% done
Checking ./trigger.c...
9/11 files checked 81% done
Checking ./triggerparser.c...
10/11 files checked 90% done
Checking ./uinput.c...
11/11 files checked 100% done
Checking usage of global functions..
[./trigger.c:1]: (style) The function 'count_triggers' is never used
[./ignore.c:1]: (style) The function 'print_ignores' is never used
stefan@exa:~/git/triggerhappy$ 

I've pushed the changes done so far to my git repository.


Reply to: