Re: RFS: python-pygene

[Benoît Knecht <benoit.knecht@fsfe.org>]

Hi Mathieu,

Mathieu Negri wrote:
> I am looking for a sponsor for my package "python-pygene".
> 
> * Package name    : python-pygene
>  Version         : 0.2.1-1
>  Upstream Author : David McNab <david@freenet.org.nz>
> * URL             : http://www.freenet.org.nz/python/pygene/
> * License         : GPL2
>  Section         : python
> 
> It builds these binary packages:
> python-pygene - simple python genetic algorithms/programming library
> 
> The package appears to be lintian clean.
> 
> The upload would fix these bugs: 592962

I had a look at your package, and just have a few comments:

 - Documentation takes the biggest part of this package. How about
   making it separate (python-pygene-doc), so that it can be installed
   only if needed?

 - demo_fractal.py has a small typo that prevents it from running
   properly:

       File "./demo_fractal.py", line 72
         )
         ^
     SyntaxError: invalid syntax

   (It should be a '}' instead.)

 - The word wrap in the bullet list in your debian/control file doesn't
   look right; for example, in the second bullet point, "dimentional"
   should be aligned with "Several".

 - patches/debian-changes-0.2.1-1 only creates a file called fold.txt,
   which contains the same information as debian/control and is not
   included in the package; I guess it's a mistake.

Cheers,

-- 
Benoît Knecht