[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: open-dis



On Mon, Aug 23, 2010 at 7:22 PM, Christoph Egger <christoph@debian.org> wrote:
James Goppert <james.goppert@gmail.com> writes:
> I am looking for a sponsor for my package "open-dis".
>
> * Package name    : open-dis
>   Version         : 2.5-1
>   Upstream Author : Don McGregor <mcgredo@users.sourceforge.net>
>
> * URL             : http://open-dis.sourceforge.net
> * License         : BSD like, with conditions
>   Section         : libs
>
> It builds these binary packages:
> libdis     - Distributed Interactive Simulation Protocol
>
> libdis-dev - Distributed Interactive Simulation Protocol
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 593009

/---
| find cpp/DIS/ -name *.h -exec cp -v {} $(CURDIR)/debian/tmp/usr/include/DIS/ \;
| find CppUtils/DIS/ -name *.h -exec cp -v {} $(CURDIR)/debian/tmp/usr/include/DIS/ \;
\---

   Any reason you're using find? One could fear you're loosing
directory structure (but there are no directories). A cp -v cpp/DIS/*.h ...
should work as well right?

/---
| % uscan --report-status
| Processing watchfile line for package open-dis...
| Newest version on remote site is enumerations-bin_1.1, local version is 2.5
| open-dis: Newer version (enumerations-bin_1.1) available on remote site:
|   http://qa.debian.org/watch/sf.php/open-dis/open-dis-enumerations-bin_1.1.tar.gz
|   (local version is 2.5)
\---

   I'd propose the following change:

/---
--- debian/watch.orig   2010-08-24 01:16:27.602516565 +0200
+++ debian/watch        2010-08-24 01:16:44.714513820 +0200
@@ -1,2 +1,2 @@
 version=3
-http://sf.net/open-dis/open-dis-(.*)\.tar\.gz
+http://sf.net/open-dis/open-dis-([\d.]*)\.tar\.g
\---

   Which changes that to

/---
| % uscan --report-status
| Processing watchfile line for package open-dis...
| Newest version on remote site is 3.0, local version is 2.5
| open-dis: Newer version (3.0) available on remote site:
|   http://qa.debian.org/watch/sf.php/open-dis/open-dis-3.0.tar.gz
|   (local version is 2.5)
\---

   Any reason to not use the up-to-date version?

Regards

   Christoph

--
9FED 5C6C E206 B70A 5857  70CA 9655 22B9 D49A E731
Debian Developer | Lisp Hacker | CaCert Assurer

A. Because it breaks the logical sequence of discussion
Q. Why is top posting bad?

Christoph,

Thanks for all the help!
I included your suggested changes. I attempted to upgrade to open-dis-3.0 and ran into some #include problems I would have to patch with quilt, but no big deal. I am just not sure on the compatibility with delta3d, they list opendis 2.5 as a dependency. So we might want to have 2.5 in there just in case. We can always upgrade to 3.0 later.

-James

P.S. Almost top posted :-)

Reply to: