Re: RFS: marave - 3rd Attempt
On Thu, Jul 1, 2010 at 6:49 AM, Chris <racerx@makeworld.com> wrote:
> Please review at your leisure.
A new version of debian-policy has been recently released, please read
upgrading.txt from it and make any changes required.
Please send the manual page upstream if you haven't already.
There are some non-free files to remove from the source package:
marave/backgrounds/Winter Landscape Classic.jpg
marave/backgrounds/Dutch winter landscape.jpg
marave/backgrounds/Landscape with sky.jpg
marave/clicks/thozi_daCLick.wav
marave/clicks/adriantnt_u_click.wav
marave/clicks/adriantnt_r_plastic.wav
marave/clicks/BEEP1A.WAV
marave/clicks/BEEP1B.WAV
marave/clicks/BEEP1C.WAV
marave/clicks/CLICK10A.WAV
marave/clicks/SERVO1A.WAV
Please note that you should add a get-orig-source target to
debian/rules that will create an appropriate orig.tar.gz without the
non-free stuff from upstream. In addition the upstream version number
needs +dfsg1 appended in debian/changelog. Alternatively, ask upstream
to remove them and make a new release.
debian/copyright lists the wrong license for the images, they are
CC-BY-2.0, CC-BY-NC-2.0 and CC-BY-SA-NC-2.0, all of which are
non-free. CC 3.0 licenses are ok, except for the NC and ND versions.
marave/backgrounds/118222-Just_Green_Curls.svgz is GPL but the SVG
contains a massive embedded PNG file. I seriously doubt that it could
be considered source code, so distributing it is probably a GPL
violation.
The icons are supposedly from the Reinhardt SVG icon set. It would be
best to package that separately and depend on it.
It might be a good idea to enable syntax highlighting, do you know if
that is possible in Debian?
Automated complaints:
dpkg-gencontrol: warning: package marave: unused substitution variable
${python:Versions}
P: marave: no-upstream-changelog
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: