[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: mpg321 (updated package with AudioScrobbler & FFT support, DM-Upload-Allowed flag removed, 2nd try)



On Thu, Jul 01, 2010 at 03:31:29PM +0200, Michal Čihař wrote:
> Hi
> 
> Dne Tue, 29 Jun 2010 22:02:56 +0300
> Nanakos Chrysostomos <nanakos@wired-net.gr> napsal(a):
> 
> > The package can be found on mentors.debian.net:
> > - URL: http://mentors.debian.net/debian/pool/main/m/mpg321
> > - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
> > - dget http://mentors.debian.net/debian/pool/main/m/mpg321/mpg321_0.2.11-4.dsc
> 
> - what is reason for removing -Wall from compiler flags?

There is no reason at all. This is a mistake trying to use the new                                                                                                                                                                           
version of autotools.

> - you should add fft.c copyright information to debian/copyright

Forgot it. Fixed already.

> 
> And what is actually motivation for adding features in Debian patches
> instead of making new upstream release?

This is a better solution.                                                                                                                                                                                                                   
I will upload a new upstream release in the next few hours.                                                                                                                                                                                  
                                                                                                                                                                                                                                             
																													     Thanks.   
> 
> -- 
> 	Michal Čihař | http://cihar.com | http://blog.cihar.com



Reply to: