Re: RFS: xburst-tools
On Fri, Jun 4, 2010 at 10:49 AM, Paul Wise <pabs@debian.org> wrote:
> On Fri, Jun 4, 2010 at 12:16 AM, Xiangfu Liu <xiangfu.z@gmail.com> wrote:
>
>> I am looking for a sponsor for my package "xburst-tools".
>
> Here is a review:
Bah, hit send too early, sorry for the double mail.
Please remove these prebuilt files from the debian/ directory and
don't add them to the upstream tarball.
./debian/xburst_stage1.bin
./debian/xburst_stage2.bin
./debian/stage1.bin
You include an embedded code copy (or fork) of the Qi bootloader.
Please remove it and package Qi separately. I wonder if usbboot/ is
also an embedded code copy.
Please use 'make distcheck' to produce a tarball for release and for
the Debian orig.tar.gz
The README.source indicates that this requires a cross-compiler for
MIPS in the $PATH. Since we don't have one in Debian yet, your package
cannot be uploaded as-is. You could however, build and upload from a
MIPS machine with gcc installed.
I stopped here, there are way too many huge issues to consider
reviewing it fully.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: