Re: RFS: xserver-xorg-video-qxl
On Wed, Apr 21, 2010 at 4:33 PM, Liang Guo <bluestonechina@gmail.com> wrote:
> I am looking for a sponsor for my package "xserver-xorg-video-qxl".
I'm not doing any additional sponsoring, but here is a quick review:
sed -i -e s/SPICE-compitable/SPICE-compatible/ debian/control
Should XSF packages have the team address in Maintainer?
One of the files is public domain, you should document that in debian/copyright.
Since you are using dpkg-source v3 (quilt), you can drop the first
paragraph of debian/README.source.
Any idea why upstream installs a .la file for the driver? Surely that
isn't needed. Do the RedHat/Fedora install it? This generates a
warning:
dh_install: usr/lib/xorg/modules/drivers/qxl_drv.la exists in
debian/tmp but is not installed to anywhere
gcc warnings to send upstream (preferrably with patch):
../../src/lookup3.c:171: warning: no previous prototype for 'hashword'
../../src/lookup3.c:215: warning: no previous prototype for 'hashword2'
../../src/lookup3.c:462: warning: no previous prototype for 'hashlittle2'
../../src/lookup3.c:646: warning: no previous prototype for 'hashbig'
../../src/qxl_mem.c: In function 'qxl_mem_dump_stats':
../../src/qxl_mem.c:96: warning: pointer of type 'void *' used in arithmetic
../../src/qxl_mem.c:96: warning: comparison of distinct pointer types
lacks a cast
../../src/qxl_mem.c: In function 'qxl_alloc':
../../src/qxl_mem.c:152: warning: pointer of type 'void *' used in arithmetic
../../src/qxl_mem.c: In function 'qxl_free':
../../src/qxl_mem.c:242: warning: pointer of type 'void *' used in arithmetic
../../src/qxl_mem.c:262: warning: pointer of type 'void *' used in arithmetic
../../src/qxl_mem.c:294: warning: pointer of type 'void *' used in arithmetic
../../src/qxl_driver.c:484: warning: 'print_region' defined but not used
../../src/qxl_driver.c:540: warning: 'paint_shadow' defined but not used
dpkg-gencontrol warning:
dpkg-gencontrol: warning: package xserver-xorg-video-qxl: unused
substitution variable ${xinpdriver:Provides}
lintian complaints:
I: xserver-xorg-video-qxl: description-possibly-contains-homepage
http://www.X.org
P: xserver-xorg-video-qxl: no-homepage-field
P: xserver-xorg-video-qxl: no-upstream-changelog
X: xserver-xorg-video-qxl: shlib-calls-exit
usr/lib/xorg/modules/drivers/qxl_drv.so
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: