Re: RFS: go

[Maximiliano Curia <maxy@debian.org>]

Hola Ivan Wong!

El 21/03/2010 a las 16:42 escribiste:
> So sounds like more people prefer "google-go". I just renamed it and
> re-uploaded it:
 
> - URL: http://mentors.debian.net/debian/pool/main/g/google-go
> - Source repository: deb-src http://mentors.debian.net/debian
> unstable main contrib non-free
> - dget
> http://mentors.debian.net/debian/pool/main/g/google-go/google-go_2010.03.15-1.dsc
 
> I hope someone will be interested in sponsoring this package. Any
> help would be greatly appreciated.

> >   Version         : 2010.03.15-1

Here is my quick review:

 - Version scheme is doomed to be changed in the future
 - A README.source would be nice to have.

 - copyright packaging holder says: Ivan Wong <Ivan Wong <ivanwyc@gmail.com>>,
   should be: Ivan Wong <ivanwyc@gmail.com>
 - go.substvars non-sense shlibs:Depends=libc6 (>= 2.3.6-6~), libc6 (>= 2.7)
   Is it really needed? (Please explain this in your README.source)
 - go.dehelper.log included in your src package isn't really needed.

 - Why would anyone prefer a static binary compiler in a full blown debian
   system? (lintian-overrides) (If there is a technical reason to be so please
   explain it in the README.source otherwise, generate dynamic binaries)

 - It would be preffered if the environment variables were not needed
   (that is, to run the compiler), setting a default on compile time would also
   avoid the need of the wrappers (debian/bin/*)
 - Please, provide manpages for the programs, even a simple one would help a
   lot.

A quick license review:
 - ./src/pkg/image/jpeg/idct.go: dubious license, its released under a BSD
   like license by the Go authors, but claims to be a translation from a non-free
   implementation

-- 
"recursividad 95, 154, 156, 201, 224, 293" 
	-- El Lenguaje de Programacion C, pag. 293 (Kernighan & Ritchie)
Saludos /\/\ /\ >< `/