Re: RFS: django-picklefield
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Jakub Wilk, 2010-03-11 21:21:
> Please don't bump revision number for every upload to mentors.
So should I stay with x.y-1 for the version with each upload?
> Python module name is "picklefield", so the binary package name should
> be "python-picklefield".
Changed it. I was under the impression that /^python-django-.*$/ would
be better since it would suggest the close relation to Django.
> Package description:
> - Please use an emotionally neutral word instead of "incredibly".
> - "automagically"[1] is used here incorrectly: the way the package works
> is understandable by anyone, no "magic" is involved.
Done. Damn myself for being a lazy bastard and copying most of the text
from upstream description of the package :-)
> Issues with upstream code:
> - According to upstream README[2], "the implementation is taken and
> adopted from [a snippet] by Taavi Taijala"; this is apparently in
> contrast with the only copyright statement (in setup.py): "Copyright (c)
> 2009 Shrubbery Software". Could you please clarify this with upstream?
Upstream is looking into it and will hopefully clarify it today.
> - According to docstrings "the pickling protocol is specified explicitly
> (by default 2)", which is not true (unless I'm blind).
You are right. self.protocol is at least set to 2 (fields.py:72) but
never used in the calls to dumps() or loads(). I emailed upstream about it.
There is another issue on which I'm not quite sure how to handle it:
While trying to contact upstream I noticed that their email address is
no longer valid. I managed to contact one of the guys through his
account on github. Is it ok for me to patch the README and setup.py to
include additional contact information? Upstream has been asked for a
valid email address.
Michael
(Thanks for providing me such great feedback, I really appreciate it!)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkuZ/EQACgkQeJ3z1zFMUGafMgCfZlLLdltskdR0RrQ6QqDfLNc+
4d4An0l+o4+6xe8MpLsbRf8Hx/0R72/J
=G3al
-----END PGP SIGNATURE-----
Reply to: