Damien Leone writes: > Hello, Hi, > I am looking for a sponsor for the new version 0.5.2 of my package > "ncmpcpp" [0] (currently uploaded version is 0.4.1). > > It builds this binary package: > ncmpcpp - ncurses-based client for the Music Player Daemon (MPD) > > The package appears to be lintian clean. > > The upload would fix these bugs: 566162 [1], 553382 [2] > > The package can be found here: > - URL: http://debian.fensalir.fr/ncmpcpp/ > - dget http://debian.fensalir.fr/ncmpcpp/ncmpcpp_0.5.2-1.dsc > > Thanks, > Regards, > > [0] http://unkart.ovh.org/ncmpcpp/ > [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=566162 > [2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=553382 Looks good, some notes: * you didn't Close: #XXXXXX these bugs from debian/changelog. * you didn't pass --enable-visualizer flag to configure as suggested in 553382, though it is autodetected, but better stay on the safe side. * as caught by cppcheck [charset.cpp:103]: (error) Mismatching allocation and deallocation: tmp [charset.cpp:120]: (error) Mismatching allocation and deallocation: tmp i.e. whatever is allocated by strdup(3) should be released by free(3), and not by delete[], even if it works by pure luck (since delete op might be implemented by free with some implementations) -- pub 4096R/0E4BD0AB <people.fccf.net/danchev/key pgp.mit.edu>
Attachment:
signature.asc
Description: This is a digitally signed message part.