Re: RFS: mpg321 (updated package)
On 25/1/2010 16:10, Michal Čihař wrote:
> Hi
>
> Dne Mon, 25 Jan 2010 12:17:39 +0200
> Nanakos Chrysostomos <nanakos@wired-net.gr> napsal(a):
>
> > I am looking for a sponsor for the new version 0.2.11-2
> > of my package "mpg321".
>
> > It builds these binary packages:
> > mpg321 - Simple and lighweight command line MP3 player
>
> > The package appears to be lintian clean.
>
> > The upload would fix these bugs: 566544
>
> > The package can be found on mentors.debian.net:
> > - - URL: http://mentors.debian.net/debian/pool/main/m/mpg321
> > - - Source repository: deb-src http://mentors.debian.net/debian unstable
> > main contrib non-free
> > - - dget
> > http://mentors.debian.net/debian/pool/main/m/mpg321/mpg321_0.2.11-2.dsc
>
> > I would be glad if someone uploaded this package for me.
>
> Please do not send same email several times, it just upsets people.
>
> Comments about the package:
>
> - there is no reason to build depend on quilt when using 3.0 (quilt)
Fixed.
> source format, you also don't need to fiddle with quilt in
> debian/rules
Fixed.
> - please use DEP-3 compliant patch headers
Fixed.
>
> Your patch:
>
> ++ //tempsample = mad_f_mul(*left_ch++, options.volume);
> ++ tempsample = (mad_fixed_t) ((*left_ch++ *
> (double)options.volume)/MAD_F_ONE);
>
> Seems obviously wrong, because one of key features of mpg321 is that it
> uses just fixed-point calculation, while you introduce floating point
> arithmetic by this patch.
>
Can you please tell me where mpg321 introduces floating point
arithmetic, especially with this patch?? This patch sends mpg321 to the
previous state. Please take a look at 0.2.10.3 , 0.2.10.6. It has
nothing to do with the decoding of the mp3 file. For the audio dithering
responsible are the functions from libmad which uses fixed-point
calculation as you can see, audio dithering function does also. This
patch will avoid compilation problems for MIPS and MIPSEL architectures
[0],[1] introduced by the use of mad_f_mul function. Please take a look
to /usr/include/mad.h. There is no difference by the introduced patch.
Package upload again to mentors.d.n.
Thanks,
Chris.
[0]:
https://buildd.debian.org/fetch.cgi?&pkg=mpg321&ver=0.2.11-1&arch=mips&stamp=1263279405&file=log
[1]:
https://buildd.debian.org/fetch.cgi?pkg=mpg321;ver=0.2.11-1;arch=mipsel;stamp=1263878672
Reply to: