Re: RFS: acetoneiso
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Nick Andrik schrieb:
> Dear mentors,
>
> I am looking for a sponsor for my package "acetoneiso".
>
> * Package name : acetoneiso
> Version : 2.2.1-1
> Upstream Author : Fabrizio Di Marco and Marco Di Antonio
> * URL : http://www.acetoneteam.org/
> * License : GPL-3
> Section : otherosfs
>
> It builds these binary packages:
> acetoneiso - Feature-rich application to mount and manage CD/DVD images.
>
> The package appears to be lintian clean.
>
> The upload would fix these bugs: 540426
>
> My motivation for maintaining this package is:
> I use this package and I think it will be useful to many people if
> included in debian.
> I have contacted the upstream authors, they are OK with my maintaining
> this software and this package is published as the official initial
> release for debian.
>
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/a/acetoneiso
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/a/acetoneiso/acetoneiso_2.2.1-1.dsc
>
> I would be glad if someone uploaded this package for me.
Hello,
here is my review:
* debian/control:
- - The package depends on ia32-libs [amd64], what the fuck? Why?
- - libqt4-gui | libqtgui4 => the right dependency is added by
shlibs:Depends
* debian/copyright:
- - The downloaded from link is not valid.
* general:
There are many useless whitespaces at EOL:
me@exez:~/build/acetoneiso/acetoneiso-2.2.1/debian$ grep -c \ $ *
changelog:7
control:4
copyright:4
lintian:
Those have to be fixed before I upload it:
I: acetoneiso: copyright-with-old-dh-make-debian-copyright
I: acetoneiso: description-synopsis-might-not-be-phrased-properly
W: acetoneiso: binary-without-manpage usr/bin/acetoneiso
I: acetoneiso: desktop-entry-contains-encoding-key
/usr/share/applications/AcetoneISO.desktop:3 Encoding
Also there are many spelling errors in the upstream source, reported by
lintian. You may patch them and send it to upstream (if they are no
false positives):
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Splitted
Split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted
split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Splitted
Split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted
split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted
split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Splitted Split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Splitted Split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Splitted Split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso succesfully
successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso Succesfully
Successfully
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso usefull useful
I: acetoneiso: spelling-error-in-binary ./usr/bin/acetoneiso splitted split
- --
/*
Mit freundlichem Gruß / With kind regards,
Patrick Matthäi
GNU/Linux Debian Developer
E-Mail: pmatthaei@debian.org
patrick@linux-dev.org
Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAktMb7oACgkQ2XA5inpabMd3qACgo54PwxyWpgH69Gt/dU90cZO5
8iQAn1jrylj2T36JT5A84Mvn/y+BDHk4
=ZxRF
-----END PGP SIGNATURE-----
Reply to: