Hello,
It seems indeed in a very good shape (lintian clean, builds in a clean
chroot, DEP-5, …). I had a look at your package and here are a few
remarks :
- dpkg-shlibdeps and dpkg-gencontrol issue a couple warnings :
dpkg-shlibdeps: warning: dependency on libgcc_s.so.1 could be
avoided if "debian/libmosquittopp0/usr/lib/libmosquittopp.so.0"
were not uselessly linked against it (they use none of its
symbols).
dpkg-gencontrol: warning: package python-mosquitto: unused
substitution variable ${python:Versions}
dpkg-gencontrol: warning: package python-mosquitto: unused
substitution variable ${python:Provides}
- debian/rules : why use "--with quilt" ? The 3.0 format can handle
the patch/unpatch logic, and you can drop the build-dep on quilt.
- debian/watch : the "this is an example" header should probably be
removed.
Cheers,
--
Etienne Millon
Attachment:
signature.asc
Description: Digital signature