[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: free42



Hello,

I am not a DD and thus can not sponsor you. However I had a look at
your package.

  - It fails to build in a clean chroot. At the beginning of the build it
    complains about missing headers :
    
        touch symlinks
        g++ -MMD -Wall -g -I/usr/X11R6/include -fno-exceptions -fno-rtti  -DVERSION="\"1.4.66\"" -c -o shell_main.o shell_main.cc
        shell_main.cc:20:21: warning: gtk/gtk.h: No such file or directory
        shell_main.cc:21:28: warning: gdk/gdkkeysyms.h: No such file or directory
        shell_main.cc:22:22: warning: gdk/gdkx.h: No such file or directory
        In file included from shell_main.cc:35:
        shell_main.h:25: error: expected initializer before '*' token
        shell_main.h:42: warning: 'typedef' was ignored in this declaration
    
    You probably need to adjust Build-Dependencies to include libgtk2-dev
    instead ok libgtk2.

  - debian/rules: I believe it can be simplified if you use the "dh
    $@" technique. "rm ChangeLog || true" should be changed to "rm -f
    Changelog" as the former ignores all errors, not only "this file
    does not exist".

  - debian/changelog should mention that it is a new package and that
    this upload would close an ITP. The "3.0 (quilt)" format is not
    relevant here as it has not changed.

As I couldn't build the package, I can't help you more, but I
encourage you to use a build system such as cowbuilder, that isolates
the package from your host system.

Hope that helps,

-- 
Etienne Millon

Attachment: signature.asc
Description: Digital signature


Reply to: