[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: zsnes (updated package - ITA)


Thanks for this review.

> Are you sure the build-deps were useless?  It could be that some of
> them are still needed but were brought in accidentally via libsdl-dev,
> for example.  (See <http://bugs.debian.org/123725>)

The package builds in a clean chroot, so I thought this was "good
enough". If this is bad practice I will have another look at it.

> > +  * Add debian/README.source to document dpatch.
> I would have used a symlink or text pointing to
> /usr/share/doc/dpatch/README.source.gz for easier maintenance.

Good idea indeed.

Thanks again,

Etienne Millon

Reply to: