[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: libharu (updated)

Dear mentors/sponsors,

I have updated my libharu package, a C library for generating pdf files.

dget http://mentors.debian.net/debian/pool/main/l/libharu/libharu_2.1.0+dfsg-1.dsc

Three notes:
1) the source package contains bindings for python, pascal, freebasic,
ruby and C#. Since my knowledge of those languages is too small to
support these bindings, I chose not to package them (yet).
2) Somewhat related: the source package contains a number of sample
programs. I was unsure what I should do with them. Package them as
documentation in the -dev package?  Or a seperate documentation
package? Packaging them as a binary package does not seem useful.
3) I used git-buildpackage to create this package. I hope someone can
create a repository on alioth (even if it is not sponsored  I hope my
packaging efforts can be stored on a more reliable place than my pc).

Apart from that, I have tried to cope with these issues, raised by Paul Wise:

> The libhpdf-dev package description should have more detail than the
> libhpdf-2.1.0 description since the latter will always be
> automatically installed and libhpdf-dev will be installed from
> build-depends and by people wanting to develop apps using the library.
> I'd suggest getting your package descriptions reviewed by debian-l10n-english.

I have rewritten the package descriptions
> You can strip the boilerplate from debian/rules (lines 2-9).
> You can strip the comments from debian/watch (lines 1-6, 8-9).
> Your watch file does not work:
> Looking at the upstream download directory, I'd strongly recommend
> they switch to a consistent naming scheme.

I agree, but at least their current build system (make dist) wiil give
names consistent with the watch file and the last release.

> The last release was a long time ago and the git repository has recent
> commits, you might want to ask them when the next release will be.

I did. However I received no answer, and my messages to their
mailinglist didn't even pass moderation. I have chosen to package the
current release, but I backported some patches to this build. The
major new functionality that would be part of the release is imho not
very relevant for most users (I have never seen pdf files with u3d
annotations). If they decide to release anyway, most of the packaging
can be reused.

> The upstream tarball contains .res files, which are compiled versions
> of the .rc files. I'd suggest that they should only ship source code
> in their source tarballs. Same comment applies to the prebuilt-PDFs
> from the demos.
> Much of the code is under a different license to the one quoted in
> debian/copyright.
> ...
I have removed all binary files and files already packaged in debian.
These changes are described in debian/copyright and a get-orig-source
target was added to debian/rules
> Some of the code references http://libharu.sourceforge.net/, which
> redirects to libharu.org.
fixed upstream and patched in this package

> lintian complaints:
> debhelper warning:
> After modifying the packaging to add -Wall to CFLAGS, one gcc warning:
> hpdf_u3d.c: In function 'HPDF_U3D_LoadU3D':
> hpdf_u3d.c:136: warning: 'type' may be used uninitialized in this function
I checked the code, and 'type' is always initialized when it is used.

On Sat, May 15, 2010 at 1:57 PM, Johan Van de Wauw
<johan.vandewauw@gmail.com> wrote:
> Dear mentors,
> I am looking for a sponsor for my package "libharu".
>  Package name    : libharu
>  Version         : 2.1.0+dfsg-1
>  Upstream Author : Takeshi Kanno <takeshi_kanno@est.hi-ho.ne.jp>,
> Antony Dovgal <tony@daylessday.org>, libharu@googlegroups.com
>  URL             : http://libharu.org
>  License         : ZLIB/LIBPNG License (see below)
>  Section         : libs
> It builds these binary packages:
> libhpdf-2.1.0 - cross platform C library for generating pdf files
> libhpdf-dev - cross platform C library for generating pdf files
> The package appears to be lintian clean.
> The upload would fix these bugs: 581397
> My motivation for maintaining this package is: This library can add
> pdf support to the saga gis package, which I packaged/maintain for
> debian.
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/l/libharu
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/l/libharu/libharu_2.1.0-1.dsc
> I would be glad if someone uploaded this package for me.
> Kind regards
>  Johan Van de Wauw
> ==
> ZLIB/LIBPNG License:
>    This software is provided 'as-is', without any express or implied warranty.
>    In no event will the authors be held liable for any damages arising from the
>    use of this software.
>    Permission is granted to anyone to use this software for any purpose,
>    including commercial applications, and to alter it and redistribute it
>    freely, subject to the following restrictions:
>     1. The origin of this software must not be misrepresented; you must not
>        claim that you wrote the original software. If you use this software in
>        a product, an acknowledgment in the product documentation would be
>        appreciated but is not required.
>     2. Altered source versions must be plainly marked as such, and must not be
>        misrepresented as being the original software.
>     3. This notice may not be removed or altered from any source distribution.

Reply to: