[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: httpry



On 24 April 2010 19:33, Yann Lejeune <ylejeune@netyl.org> wrote:
> http://mentors.debian.net/debian/pool/main/h/httpry/httpry_0.1.5-1.dsc

Sorry for my lack of response... again.

You've removed 'quilt' from debian/control, but debian/rules still
contains quilt lines - sorry for not being clearer earlier. I would
take this opportunity to switch to a minimal dh7 rules file, if you
can.

I still find it odd that httpry.dirs is necessary.  You could use the
'-D' option to 'install' in the Makefile, since you're patching it
already.

I think I understand the init script argument, but I find it odd that
the program has a daemon mode at all (with a hardcoded pidfile path in
/var/run) which we're basically not supporting.  I haven't made up my
mind about it yet - you would probably have to rewrite that init
script based on the skeleton in /etc/init.d, and add an 'httpry' user
during the postinst so that you don't have to parse the config file
before you drop privileges...

-- 
Tim Retout <tim@retout.co.uk>


Reply to: