Re: RFS: gedit-r-plugin
On Wed, May 19, 2010 at 07:42, Mateusz Kaduk <mateusz.kaduk@gmail.com> wrote:
> Dear mentors,
>
> I am looking for a sponsor for my package "gedit-r-plugin".
Here are some comments:
debian/changelog:
- remove -2 entry: the changelog is about the change you did from an
upload to Debian archive to the previous, since it's a new package,
there is no previous version, so just stick with -1 entry
debian/control
- what about enabling those Vcs-* field?
- you need python at runtime, so the binary pacakge has to define a
Depends on it. I suggest to try adding the ${python:Depends} variable,
and if it not works, add an explicit 'python' Depends
- also, you need to Depends, or at least Recommends/Suggests
r-base-core (i tried the plugin and got "R --no-save --no-restore
bash: R: command not found")
debian/format
- remove it
debian/patches/get_data_dir
- what does this patch do?
debian/README.Debian
- this information belongs to debian/copyright (the describe how to
obtain the tarball), so merge them there and remove this file
debian/rules
- you decided to use debhelper 7, so I strongly suggest to use its
tiny rules file (/usr/share/doc/debhelper/examples/rules.tiny) +
override instead of cdbs, that's mainly "black magic"
ReadMe.txt
- install it as documentation
> The package appears to be lintian clean.
ehm, not exactly :)
lintian -iIv --pedantic gedit-r-plugin_0.7.0-2_amd64.changes
...
I: gedit-r-plugin source: quilt-patch-missing-description get_data_dir
...
I: gedit-r-plugin source: debian-watch-file-is-missing
...
P: gedit-r-plugin: no-upstream-changelog
for sure, add a debian/watch file
Once done this changes, feel free to resubmit the package and the RFS.
Regards,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: