Re: Please review internal package using a lot of "new" tools
On Sun, May 23, 2010 at 6:14 AM, Marc Haber
<mh+debian-mentors@zugschlus.de> wrote:
> I would appreciate if you could comment.
dh --with-quilt isn't needed if you're using dpkg-source v3
If you call dh_auto_configure -- ... instead of ./configure ... it
will add --prefix for you.
The test parts of override_dh_auto_build should go into override_dh_auto_test.
In dh_auto_install, does upstream's Makefile not support DESTDIR?
You can use $(CURDIR) instead of $(shell pwd), that will save a few
process spawnings.
I also note that it uses /tmp/check_multi and wonder if that enables
any symlink attacks.
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: