Re: Request for review of my sciteproj package

[Andreas Rönnquist <gusnan@gusnan.se>]

On Wed, 19 May 2010 22:18:28 -0500
Ruben Molina <rmolina@udea.edu.co> wrote:

> On mié, 2010-05-19 at 22:46 +0200, Andreas Rönnquist wrote:
> > Could someone please be so kind to review my sciteproj package?
> > dget http://mentors.debian.net/debian/pool/main/s/sciteproj/sciteproj_0.3.7-1.dsc
> 
> I'm not a DD but I did a quick check to your package, and here are some
> comments on your debian/copyright:
> 
> I think you should use more verbosity here, as you are listing © 2006
> Roy Wood and © 2010 Andreas Ronnquist, but there are files with
> copyright years 2008 and 2009. In fact there are four distinct copyright
> boilerplates:
> 
>       * Copyright 2006 Roy Wood, 2008 Andreas Ronnquist
>       * Copyright 2006 Roy Wood, 2009 Andreas Ronnquist
>       * Copyright 2009 Andreas Ronnquist
>       * Copyright 2008,2009,2010 Andreas Ronnquist
> 
> Also you should link to /usr/share/common-licenses/GPL-3 instead
> of /usr/share/common-licenses/GPL, because the package is GPL3+.
> 
> And check for a '(C)' without the full word 'Copyright' at the Debian
> packaging copyright boilerplate, '(C)' is not considered as a valid way
> to express the copyright ownership.
> 

Thank you Ruben! 

All these should be fixed in my latest upload. 
Also, I discovered and fixed a faulty link the debian/copyright.

Many thanks!

best regards
-- 
Andreas Rönnquist <gusnan@gusnan.se>