Re: RFS: amispammer
Hi,
Also some comments about the upstream program:
· 'require "getopt.pl";'
This is no longer maintained and deprecated. It only exists for
compatibility with Perl 4(!) programs. getopt.pl suggests
Getopt::Long or Getopt::Std as alternatives.
· 'system("renice 20 $$ > /dev/null") if ($OSNAME ne "MSWin32");'
Perl has a setpriority function. See perlfunc(1).
· Use of threads:
I believe that using Net::DNS::Async instead of starting over 90
threads for one DNS query each would make more sense. Or use
Net::RBLClient, a Perl module to query multiple RBLs in parallel.
· auto_get_ip:
Screen-scraping web pages is likely to break in the future.
Also using split twice instead of /.../ to directly extract the IP
address is bad.
· Using "use strict;" and "use warnings;" is usually a good idea.
Upstream author has commented from BTS and will take these changes in next releases, please see:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=579499
Kind Regards,
--
Julián Moreno Patiño
Registered GNU Linux User ID 488513
PGP KEY ID 6168BF60
Reply to: