[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: django-picklefield

* Michael Fladischer <michael@fladi.at>, 2010-03-11, 13:33:

Please don't bump revision number for every upload to mentors.

Python module name is "picklefield", so the binary package name should be "python-picklefield".

Package description:
- Please use an emotionally neutral word instead of "incredibly".
- "automagically"[1] is used here incorrectly: the way the package works is understandable by anyone, no "magic" is involved.

Issues with upstream code:
- According to upstream README[2], "the implementation is taken and adopted from [a snippet] by Taavi Taijala"; this is apparently in contrast with the only copyright statement (in setup.py): "Copyright (c) 2009 Shrubbery Software". Could you please clarify this with upstream? - According to docstrings "the pickling protocol is specified explicitly (by default 2)", which is not true (unless I'm blind).

[1] http://catb.org/jargon/html/A/automagically.html
[2] http://github.com/shrubberysoft/django-picklefield

Jakub Wilk

Attachment: signature.asc
Description: Digital signature

Reply to: