[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sweethome3d

Hash: SHA1


Dne Mon, 01 Mar 2010 19:01:36 +0100
Gabriele Giacone <1o5g4r8o@gmail.com> napsal(a):

> On 03/01/2010 08:51 AM, Michal Čihař wrote:
> > The license seems to be GPL-2+ (at least all file headers I checked say
> > so). Please fix it in debian/copyright.
> "you can redistribute it and/or modify it under the terms of the GNU
> General Public License as published by the Free Software Foundation;
> either version 2 of the License, or (at your option) any later version."
> At our option, we can choose GPL-3+, can't we?

What would be the reason for that?

Yes, technically you can, but you are supposed to describe actual
license in debian/copyright.

> > Why is needed 01noMacOSX? All MacOSX code seems to be behind if, so it
> > should be safe to stay, or am I wrong?
> Removed some references to MacOSX code. Without those removals, build
> fails due to classes included in AppleJavaExtension.jar which I didn't
> replace. I didn't take a deeper look at it.

I would be good idea to document this in patch description. It's always
good to mention why the patch is needed when it is not obvious.

> > Why do you install startup script to usr/share/sweethome3d and create
> > symlink in usr/bin? I think it should be directly in usr/bin.
> I already did it for jxplorer: link without .sh extension under /usr/bin
> that refers to the script under share/<application>
> /usr/bin/sweethome3d -> ../share/sweethome3d/sweethome3d.sh
> I like it but we can talk about it.

Well I feel the symlink and different location is useless, but

- -- 
	Michal Čihař | http://cihar.com | http://blog.cihar.com
Version: GnuPG v1.4.10 (GNU/Linux)


Reply to: