[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: opencpn

On Mon, Feb 8, 2010 at 6:28 AM, Anton Martchukov <anton@martchukov.com> wrote:

> I am looking for a sponsor for my package "opencpn".

Some comments on the debian.tar.gz part of the source package:

Standards-Version is out of date, please read the upgrading document
and make any changes appropriate.

debian/watch doesn't really need any comments or blank lines, you can
remove them. Same for the comment in debian/rules.

I'd suggest adding DEP3 compliant headers to the patches:


Please ensure the .desktop file installed into the binary package
validates with desktop-file-validate, IIRC Icon should not be an
absolute path and should not have an extension.

Generally it isn't a good idea to patch Makefile.in without patching
Makefile.am, what is the reason for that?

I assume you've sent the manual page and patches upstream?

Please ensure that this lintian command produces no complaints:

lintian --info --display-info --display-experimental --pedantic
--show-overrides --checksums --color auto

I'll take a closer look at the package when I'm on a Debian system.
Great to see it supports CM93 BTW.

> Note that there are two lintian warnings that I left:
> W: opencpn source: configure-generated-file-in-source config.log
> W: opencpn source: configure-generated-file-in-source config.status
> Not sure how critical are they, if they are not, I would
> better work with upstream to fix it there directly.

Upstream should use automake's 'make distcheck' to create tarballs for
distribution, best teach them about it.



Reply to: