Re: RFS: yui-compressor
-----BEGIN PGP SIGNED MESSAGE-----
Michael Gilbert schrieb:
> On Wed, 30 Dec 2009 11:42:55 +0100 Patrick Matthäi wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> Michael Gilbert schrieb:
>>> Dear mentors,
>>> I am looking for a sponsor for my package "yui-compressor".
>>> * Package name : yui-compressor
>>> Version : 2.4.2-1
>>> It builds these binary packages:
>>> The upload would fix these bugs: 519938
>>> My motivation for maintaining this package is: the protoaculous package
>>> that I will also be maintaining requires yui-compressor to build.
>>> The package can be found on mentors.debian.net:
>>> - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free
>>> - dget http://mentors.debian.net/debian/pool/main/y/yui-compressor/yui-compressor_2.4.2-1.dsc
>>> I would be glad if someone uploaded this package for me.
>> Wouldn't it be better to give the version as parameter, which you get in
>> your debian/rules about stripping the debian/changelog?
>> You are missing patch descriptions.
The comments should start with a "# " and two newlines after the text.
>> It states, that you are using dpatch, which is wrong.
>> Looks like you are not cleaning your build tree prop., there is still
>> your created src/ directory available.
>> Your diff is also not clean:
>> dpkg-source: info: upstream files that have been modified:
> I have addressed these issues and others; including patching for the
> rhino system library. The new version is now available on mentors:
There is also a false positive which should be overwritten/reported
44 Mike Ang => I: yui-compressor: spelling-error-in-copyright Ang And
Anyway I will upload it.
Mit freundlichem Gruß / With kind regards,
GNU/Linux Debian Developer
Always if we think we are right,
we were maybe wrong.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
-----END PGP SIGNATURE-----