Re: RFS: stx-btree
> Thanks for your help, i have fixed flaws you notice.
>
Hi,
* your binary-indep should not depend on targets that try compile the test-
suites (speedtest, wxbtreedemo, testsuite), but should only install
architecture independent parts of the source package into the corresponding
-dev (headers files containing templates) and -doc (doxygen files) binary
packages.
* your binary-arch can compile the test-suites and eventually clean the
resulting object files right after that, in order to verify it succeeds on
various architectures, and should not install anything into binary package
directories since your source package does not have architecture dependent
binary packages (arch: any or arch: <list>). However, since your source
package only has two architecture independent binary packages (arch: all) and
currently Debian autobuilders do not build these parts (but only architecture
dependent ones via dpkg-buildpackage -B, actually your source package won't
even reach the autobuilders) these test-suites will only be built on the
architecture uploading DD happens to use. That will hopefully change in the
near future when autobuilders start to build every part of the source package
themselves.
As a side note: to be honest it doesn't make any big difference whether you
compile the test-suite within binary-arch or binary-indep, since you throw out
the resulting object files anyway once completed, but I guess the style is best
to be kept sane ;-) Also, at some later point you might decide to split a
separate wxbtreedemo binary package (arch:any) so it must be handled by
binary-arch anyway (debian policy 4.7).
* there are some more build-dependencies (wx, cppunit) you could add related
to test-suites, though configure script handles these gracefully if they are
not present, but you want to run the test-suite after all ;-).
* long description could be improved based on the top-level README file (add
some salt, like what improvements these containers bring over STL ones)
* debian/copyright is incomplete - there are GPL-2'ed source files in
wxbtreedemo directory (licensecheck -r . from devscripts package might be of
service). Also, /usr/share/common-licenses/LGPL is a symlink, you want to use
LGPL-2.1 in your copyright file, same for GPL-2.
* add README.Debian explaining there is no corresponding library package
containing object files, but only a development one; also point out that test-
suites could serve as examples and could be found in the source package
itself.
--
pub 4096R/0E4BD0AB <people.fccf.net/danchev/key pgp.mit.edu>
Reply to: