[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: jmdns

Salut Damien,

On Thu, Oct 8, 2009 at 8:42 PM, Damien Raude-Morvan <drazzib@debian.org> wrote:
Hi Mathieu,

Le samedi 03 octobre 2009 11:08:33, Mathieu Malaterre a écrit :
It builds these binary packages:
libjmdns-java - A Java implementation of multi-cast DNS (Apple Rendezvous)
The upload would fix these bugs: 486697
I would be glad if someone uploaded this package for me.

Some comments about this package :

- You have build a debian-native package (debian/ directory in
jmdns_2.1-1.tar.gz). You should remove debian/ directory and rename this to

- debian/control:
 * I won't sponsor a "DM-Upload-Allowed: yes" package for a NEW one.
 * Source: jmdns with Section: libs and only one Package: libjmdns-java
Section: java. You should set Source: jmdns with Section: java  use
inheritance to binary packages
 * Move openjdk-6-jdk from B-D-I to B-D
 * Short description should not start with "A..." [1]
 * You should set Vcs-* fields to pkg-java SVN repository

- debian/copyright
 *  You should use DEP-5 [2] instead of
 * You should swap Files: * and Files: debian/* (DEP-5: "it is recommended for
clarity that the stanzas appear in order from most general (e.g. Files: *)
first, through to most specific")
 * debian/* are copyright Yann Rouillard. And you ? :)
 * You should include in debian/copyright a note about upstream switch from
LGPL-2.1 to ASL-2 (to explain two LICENCE files in root directory)
 * AFAIK, some files are still licensed under LPGL [3]
 * Upstream should include ASL-2.0 headers [4]

- You should build a separate -doc package for Javadoc API

[1] http://www.debian.org/doc/manuals/developers-reference/best-pkging-
[2] http://dep.debian.net/deps/dep5/
[3] LGPL-2.1 files :
[4] http://apache.org/licenses/LICENSE-2.0.html "How to apply the Apache
License to your work"

You should, at least, fix the most important issues before I'll sponsor this

I had to remove + reupload the package (my version of gzip would produce incompatible orig file). So here it is again:


I think I got everything ok; excep your last remark:

 * Upstream should include ASL-2.0 headers [4]

What should I do about that ?

Thanks again for your time.

Attachment: signature.asc
Description: OpenPGP digital signature

Reply to: