[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: qwit (updated package)



On Tue, Sep 29, 2009 at 6:28 PM, Patrick Matthäi <pmatthaei@debian.org> wrote:
> Hello,

 Hello Patrick. Thanks for your help.

> there are some issues:
> 1) interdiff states much more changes as you described in your changelog
> (e.g. debian/rules).

 There are big upstream changes, but debian dir doesn't change very much.

 Find attached a diff file comparing the new debian dir with the previous one

 How do you find changes in debian/rules? This particular file is
untouched. Interdiff seems to think that *everything* is new...I'm a
little lost here.

> 2) It is not a new upstream version, it is a new svn snapshot and please
> describe the upstream issue in your changelog, like:
>  * New upstream svn snapshot.
>    - Fixes issue X, where it does not update bar.
>  * Next entry.

 You're right. With 'new version' I meant 'first package built from
the future stable branch' :).
 I've rephrased and detailed changes in a new package already uploaded
to mentors. [1]

> 3):
> make[1]: Entering directory `/tmp/buildd/qwit-1.0+svn255'
> /usr/bin/uic-qt4 src/MainWindow.ui -o var/ui_MainWindow.h
> make[1]: svnversion: Command not found
> for every line, is this wanted?

 It replaces the 'revision' property with the svn 'head' revision
number for each file.

 I guess this is not _needed_ but _wanted_ either by the upstream or
by the IDE. Obviously, 'subversion' should be added to Build-depends
in order to fix this errors (not done yet), but I don't find this is
very elegant.

 The other option is to talk with upstream about "how much does he
need it" and come to an agreement with him (he is quite nice and
responsive).

Regards.

[1] http://mentors.debian.net/debian/pool/main/q/qwit/qwit_1.0+svn255-1.dsc

-- 
---
Carlos Galisteo <cgalisteo AT k-rolus.net>
GPG keys & fingerprints:
0x8E0076E9 -> 939E 3D10 EAA2 A972 3AF2  E25C 26B7 D8E3 8E00 76E9
0x69ADBE65 >  F888 6FBA 9145 B5A2 C187 66D6 5B8C 027A 69AD BE65
---
Only in debian/: README.source
diff -ru /tmp/qwit-0.9/debian/changelog debian/changelog
--- /tmp/qwit-0.9/debian/changelog	2009-09-29 18:35:03.000000000 +0200
+++ debian/changelog	2009-09-30 12:13:22.000000000 +0200
@@ -1,3 +1,17 @@
+qwit (1.0+svn255-1) unstable; urgency=low
+
+  * New upstream svn snapshot providing some bug fixes and new features:
+    - Upstream moved to 1.x branch.
+    - Fixes 'Twitpocalypse' related bugs (int limit reached).
+    - Url shorteners support.
+    - Multiple accounts support.
+    - Identi.ca and other twitter-compatible services support.
+  * Updated Standards-Version to 3.8.3 No change needed.
+  * Added README.source file.
+  * Crystal Project Icons license detailed in debian/copyright.
+
+ -- Carlos Galisteo <cgalisteo@k-rolus.net>  Tue, 29 Sep 2009 16:58:18 +0200
+
 qwit (0.9-1) unstable; urgency=low
 
   * Initial release (Closes: #528189)
diff -ru /tmp/qwit-0.9/debian/control debian/control
--- /tmp/qwit-0.9/debian/control	2009-09-29 18:35:03.000000000 +0200
+++ debian/control	2009-09-29 17:00:24.000000000 +0200
@@ -3,7 +3,7 @@
 Priority: extra
 Maintainer: Carlos Galisteo <cgalisteo@k-rolus.net>
 Build-Depends: debhelper (>= 7), quilt, txt2man, qt4-qmake, libqt4-dev
-Standards-Version: 3.8.2
+Standards-Version: 3.8.3
 Homepage: http://code.google.com/p/qwit/
 
 Package: qwit
diff -ru /tmp/qwit-0.9/debian/copyright debian/copyright
--- /tmp/qwit-0.9/debian/copyright	2009-09-29 18:35:03.000000000 +0200
+++ debian/copyright	2009-09-30 11:17:29.000000000 +0200
@@ -20,6 +20,9 @@
     TwitPicDialog.cpp, TwitPicDialog.h:
     Copyright (C) 2009 Roopesh Chander <roop@forwardbias.in>
 
+    Crystal Project Icons:
+    Copyright (C) 2009 Everaldo Coelho <everaldo@everaldo.com>
+
 License:
 
     This program is free software; you can redistribute it and/or modify
@@ -38,6 +41,14 @@
     the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
     Boston, MA 02110-1301 USA.
 
+The Crystal Project Icons are released under LGPL:
+
+    You should have received a copy of the GNU General Public License with
+    your Debian GNU system, in /usr/share/common-licenses/LGPL, or with the
+    Debian GNU hello source package as the file COPYING.  If not, write to
+    the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+    Boston, MA 02110-1301 USA.
+    
 
 


Reply to: