[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: sxid (updated package)

Hi George,

Thanks for your review.

George Danchev wrote:

> [./source/notify.c:112]: (error) Resource leak: mail_pipe

In source/notify.c on lines 78-79:

    if (!nomail)
        mail_pipe = popen (buffer, "w");

and (lines 108-109):

    if (!nomail)
        pclose (mail_pipe);

It seems that resource properly released?

> [optional] Adding a watch file would help Debian External Health Service
> [to
> catch package lagging behind new upstream releases, even though you are in
> charge with both, but discrepancies happen sometimes.

OK. Added.


Reply to: