Michal On Thu, Jul 30, 2009 at 5:11 PM, Michal Čihař<nijel@debian.org> wrote:
Thanks for packaging cdash, I use it for quite some time, but haven't found time to package it.
You seems to be a DD, I guess you should have write access to the git rep: http://git.debian.org/?p=collab-maint/cdash.git;a=summary I am not sure I fully grasp the notion of collab-maint, but I guess you could just patch directly there.
Let's start with lintian check: W: cdash source: binary-arch-rules-but-pkg-is-arch-indep
I still do not understand how to use dh_make I guess. I rename binary-arch to binary-indep. Thx.
W: cdash source: changelog-should-mention-nmu W: cdash source: source-nmu-has-incorrect-version-number 1.4.2-1
Reading the lintian report, it seems it is ok as long as the version *exactly* match the official one.
W: cdash source: maintainer-also-in-uploaders
oops.
Other things: - you miss DEBHELPER token in postinst
ok
- drop useless commented lines from debian/rules and debian/watch
ok
- you might want to use dh to simplify debian/rules
Never used that one before, thanks.
- it would be great to create database during installation using dbconfig-common
I'll investigate.
- there is no need to depend on apache, any webserver with PHP support will work
ok
- why do you depend on libapache2-mod-auth-mysql?
removed
Thanks, -- Mathieu
Attachment:
signature.asc
Description: OpenPGP digital signature