[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: concordance



-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Mathieu Trudel-Lapierre schrieb:
> Thanks.
> 
> I've applied the suggested changes to the files, and pushed it back on
> mentors.debian.net. It's using the same version number as before, just
> overwrote the files. Not sure if this is the preferred way to do this.
> I'm aware that it's definitely not the case in a "proper" repository
> :)
> 
> Mathieu Trudel
> mathieu.tl@gmail.com

Hello,

please always have the link to the dsc somewhere :)
http://mentors.debian.net/debian/pool/main/c/concordance/concordance_0.21-1.dsc


First do a 'grep -c \ $ *' in your debian/ dir and fix it.

Why are you using a versioned build-depend on python-all-dev with a
debian revision in it? Is there any special reason?

libconcord1-dev should have a binary:Version versioned depend on
libconcord1.

Do you have realy tested your package? python-concordance is empty. Also
I do not think that it has to be arch:any and it should (wheter it is
arch:{all,any} a >= source:Version or binary:Version depend on libconcord1.

Line 16, 28, 40 and 55 are too long in control, you would have find it
out with lintian.

- --
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

E-Mail: pmatthaei@debian.org
        patrick@linux-dev.org

Comment:
Always if we think we are right,
we were maybe wrong.
*/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkonoyQACgkQ2XA5inpabMf7pQCbBsLSAfo4CnSfLeh//L4uNe+u
Rt8Anid/WF3TjZvXuVJLdSgqdT5CXvom
=W0sm
-----END PGP SIGNATURE-----


Reply to: