Re: RFS: arc-colors
On Mon, May 4, 2009 at 7:27 PM, Evgeni Golov <evgeni@debian.org> wrote:
> Hi Andrew, Benjamin,
[snip]
> First of all: they build fine in a clean cowbuilder and in an unclean
> sid environment, are lintian clean and seem to work fine (I'm not using
> GNOME, so I wasn't able to test the metacity theme, only the Xfwm one
Well, I use GNOME and can attest to the fact that they work there as well. =)
>
> Second: you use cdbs, which is mainly a blackbox for me. Nothing
> against you using it, just don't expect answers on questions about it :)
>
> Now come my remarks.
>
> Package versions/links:
> gnome-colors 3.1-1 and not 3.0.5-1
> shiki-colors 3.8-1 and not 3.5-1
> You usually want to post a follow-up to your initial RFS, so potential
> sponsors notice the change.
>
Sorry, there were new upstream releases since the initial RFS. You're
absolutely right.
> */debian/control:
> + Vcs-Bzr should be Vcs-Browser? Vcs-Bzr should be a URL one can
> checked out directly.
If you'd like we could add Vcs-Browser fields as well, but in fact
the Launchpad/Bzr URLs can be used both in the web browser and
directly from the command-line. Try:
bzr branch https://code.launchpad.net/~gnome-cors-packagers/arc-colors-pkg/debian/
> + Some Descriptions start with an "a" -- that shouldn't be there.
>
Thought we caught them all. Fixed in new upload to mentors.
> */debian/copyright:
> + You write "Copyright: (C) ...", that's AFAIK legally wrong, you
> either have to write "Copyright" or ©
Fixed in new upload to mentors.
> + You don't provide a revision of the Wiki page you're refering to,
> and as a wiki might change, I'd add it like this:
> http://wiki.debian.org/Proposals/CopyrightFormat?action=recall&rev=454
Heh. That page was changing so much for awhile. I intended simply to
show that it was the general approach we were taking. Fixed in new
upload to mentors.
> + You co-maintain the packages, but only Andrew has copyright?
I did the initial packaging. Benjamin is added in the new uploads to mentors.
> shiki-colors-3.8/debian/control:Package: shiki-colors-xfwm-theme
> + I'd add an "Xfce4" somewhere to the description (like Xfwm/Xfce4
> theme based ...) as people tend to search for Xfce and not for Xfwm
> (or at least I do ;))
Done.
> + Depends: xfwm4, but shiki-colors-metacity-theme does not depend on
> metacity but gtk2-engines-clearlooks? I have no idea about
> GNOME/Metacity, maybe you just need to explain this one to me :)
Right again, shiki-colors-metacity-theme now depends on metacity in new upload.
Any suggestions about the XFWM theme would be appreciated. Is there a
more minimal package that it could depend on?
> gnome-colors-3.1/debian/copyright:
> + You write Copyright (C) 2009, Victor C.<perfectska04@gmail.com>, but
> AUTHORS says stuff is taken from Tango etc, this should be listed in
> copyright too
There was an X-Comment field mentioning Tango. I've tried to be much
more verbose in the new upload. Please review.
> + This maybe apply to the other packages too, but they do not contain
> an AUTHORS file
>
The other packages are the sole work of Victor C. to the best of my knowledge.
> gnome-colors-3.1/Extras:
> + I wonder about the copyright/source of those?
>
Upstream has removed that directory from the tarball. I'm not sure of
their reason.
> That's all for now, maybe I find more, but I hope not :)
>
Thanks so much for the review
- Andrew Starr-Bochicchio
> Regards
> Evgeni
>
> --
> Bruce Schneier Fact Number 76:
> Bruce Schneier PGP signs his grocery lists so that he can detect if
> someone has tampered with his milk.
>
Reply to: