Re: RFS: boats

[LI Daobing <lidaobing@debian.org>]

Hello,

On Tue, Apr 28, 2009 at 06:00, Thibaut GRIDEL <tgridel@free.fr> wrote:
> Hello again,
>
> * LI Daobing [2009-04-27 13:34]:
>> Hello,
>>
>> On Sun, Apr 26, 2009 at 07:31, Thibaut GRIDEL <tgridel@free.fr> wrote:
>> > Dear mentors,
>> >
>> > It builds these binary packages:
>> > boats      - a race scenario drawing tool
>> >
>> > The package appears to be lintian clean.
>> >
>> > The package can be found on mentors.debian.net:
>> > - URL: http://mentors.debian.net/debian/pool/main/b/boats
>> > - Source repository: deb-src http://mentors.debian.net/debian unstable
>> >  main contrib non-free
>> > - dget
>> >  http://mentors.debian.net/debian/pool/main/b/boats/boats_200904-1.dsc
>> >
>> > I would be glad if someone reviewed and uploaded this package for me.
>> >
>> comments:
>>
>> 1. does not close ITP bug in changelog
> Done.
>
>> 2. no menu and no desktop file, please consider provide at least one of them.
> I have provided upstream desktop file, sharedmimeinfo and icons
> then used those in debian/rules
>
>> 3. Vcs-Git in debian/control should point to the debian branch
> AFAIU, it is not possible to specify a particular branch with Vcs-Git
> naming (seen #508433 and didn't find better Vcs-Git info with regards
> branches). Hence I removed the entry.
>
sounds almost OK for me:

one comment:
1. no debian/watch and no get-orig-source in debian/rules, please
provide at least one,

thanks.

-- 
Best Regards
LI Daobing