Re: RFS: smplayer (updated package)
On Sat, Apr 18, 2009 at 16:56, Maia Kozheva <inetperson@gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> I'm the same person - I have been uploading packages to Ubuntu as Maia for some
> time (including smplayer and smplayer-themes, which I maintain in both Debian
> and Ubuntu). This is my first upload to Debian under the new name. I suppose I
> should have clarified that from the start. As for the reasons for the
> contributor name change, you can probably guess from the names themselves and it
> would probably be unwise to raise that topic in a public mailing list. :)
Ehm ehm... I hope you're not embarrassed by this situations, like I'm now :)
> My GPG key and email address stay the same, and the old name is on the key as well.
That's good.
Getting back to technical/packaging stuff:
debian/changelog:
- no need to include ubuntu changelog in debian upload (i.e., rm it)
- I encourage to list all the changes you did in the package into the
changelog, for example ${misc:Depends} add, standards-version bump are
all missing
debian/control:
- standards-version is now at 3.8.1, please update
- bump to 3.8.0 specifically require to add debian/README.source in
case of patch systems, present here but no README.source.
- mplayer-nogui is not available in Debian, you can remove it
debian/copyright
- why don't you claim any copyright on packaging other that "cyril
<cyrilbport@gmail.com>". Your work should be listed there too.
- please only refer to /usr/share/common-licenses/GPL-2 , no need to
list GPL-3 too.
- please check EVERY SINGLE FILE in the upstream tarball for copyright
and license information; from a very fast look, there are at list some
copyright year missing: "Copyright: 2006-2009 Ricardo Villalba
<rvm@escomposlinux.org>"
debian/rules:
- what's the purpose of get-orig-source? isn't --repack option of
uscan enough to create a .tar.gz from a .tar.bz2 ?
The package FTBFS in a clean chroot, probably due to some missing
build-depends (it was strange only 'libqt4-dev' was needed...):
>>>
g++ -c -pipe -O2 -Wall -W -D_REENTRANT -DNO_DEBUG_ON_CONSOLE
-DDOWNLOAD_SUBS -DDATA_PATH=\"/usr/share/smplayer\"
-DDOC_PATH=\"/usr/share/doc/packages/smplayer\"
-DTRANSLATION_PATH=\"/usr/share/smplayer/translations\"
-DTHEMES_PATH=\"/usr/share/smplayer/themes\"
-DSHORTCUTS_PATH=\"/usr/share/smplayer/shortcuts\" -DQT_NO_DEBUG
-DQT_XML_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -DQT_SHARED
-I/usr/share/qt4/mkspecs/linux-g++ -I. -I/usr/include/qt4/QtCore
-I/usr/include/qt4/QtCore -I/usr/include/qt4/QtNetwork
-I/usr/include/qt4/QtNetwork -I/usr/include/qt4/QtGui
-I/usr/include/qt4/QtGui -I/usr/include/qt4/QtXml
-I/usr/include/qt4/QtXml -I/usr/include/qt4 -Ifindsubtitles
-Ivideopreview -Impcgui -Ifindsubtitles/filedownloader
-Ifindsubtitles/quazip -I.moc -I.ui -o .obj/findsubtitleswindow.o
findsubtitles/findsubtitleswindow.cpp
In file included from findsubtitles/quazip/quazip.h:39,
from findsubtitles/findsubtitleswindow.cpp:39:
findsubtitles/quazip/zip.h:54:18: error: zlib.h: No such file or directory
In file included from findsubtitles/quazip/zip.h:58,
from findsubtitles/quazip/quazip.h:39,
from findsubtitles/findsubtitleswindow.cpp:39:
findsubtitles/quazip/ioapi.h:38: error: ISO C++ forbids declaration of
'voidpf' with no type
findsubtitles/quazip/ioapi.h:38: error: typedef 'voidpf' is
initialized (use __typeof__ instead)
findsubtitles/quazip/ioapi.h:38: error: 'open_file_func' was not
declared in this scope
findsubtitles/quazip/ioapi.h:39: error: ISO C++ forbids declaration of
'uLong' with no type
findsubtitles/quazip/ioapi.h:39: error: typedef 'uLong' is initialized
(use __typeof__ instead)
findsubtitles/quazip/ioapi.h:39: error: 'read_file_func' was not
declared in this scope
findsubtitles/quazip/ioapi.h:40: error: ISO C++ forbids declaration of
'uLong' with no type
findsubtitles/quazip/ioapi.h:40: error: typedef 'uLong' is initialized
(use __typeof__ instead)
findsubtitles/quazip/ioapi.h:40: error: 'write_file_func' was not
declared in this scope
findsubtitles/quazip/ioapi.h:41: error: expected initializer before 'OF'
findsubtitles/quazip/ioapi.h:42: error: expected initializer before 'OF'
findsubtitles/quazip/ioapi.h:43: error: expected initializer before 'OF'
findsubtitles/quazip/ioapi.h:44: error: expected initializer before 'OF'
findsubtitles/quazip/ioapi.h:48: error: 'open_file_func' does not name a type
findsubtitles/quazip/ioapi.h:49: error: 'read_file_func' does not name a type
findsubtitles/quazip/ioapi.h:50: error: 'write_file_func' does not name a type
findsubtitles/quazip/ioapi.h:51: error: 'tell_file_func' does not name a type
findsubtitles/quazip/ioapi.h:52: error: 'seek_file_func' does not name a type
findsubtitles/quazip/ioapi.h:53: error: 'close_file_func' does not name a type
findsubtitles/quazip/ioapi.h:54: error: 'testerror_file_func' does not
name a type
findsubtitles/quazip/ioapi.h:55: error: 'voidpf' does not name a type
findsubtitles/quazip/ioapi.h:60: error: expected initializer before 'OF'
In file included from findsubtitles/quazip/quazip.h:39,
from findsubtitles/findsubtitleswindow.cpp:39:
findsubtitles/quazip/zip.h:67: error: 'voidp' does not name a type
findsubtitles/quazip/zip.h:89: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:90: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:91: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:92: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:93: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:94: error: 'uInt' does not name a type
findsubtitles/quazip/zip.h:100: error: 'uLong' does not name a type
findsubtitles/quazip/zip.h:103: error: 'uLong' does not name a type
findsubtitles/quazip/zip.h:104: error: 'uLong' does not name a type
findsubtitles/quazip/zip.h:114: error: 'zipFile' does not name a type
findsubtitles/quazip/zip.h:134: error: 'zipFile' does not name a type
findsubtitles/quazip/zip.h:139: error: expected initializer before
'zipOpenNewFileInZip'
findsubtitles/quazip/zip.h:163: error: expected initializer before
'zipOpenNewFileInZip2'
findsubtitles/quazip/zip.h:179: error: expected initializer before
'zipOpenNewFileInZip3'
findsubtitles/quazip/zip.h:204: error: expected initializer before
'zipWriteInFileInZip'
findsubtitles/quazip/zip.h:211: error: expected initializer before
'zipCloseFileInZip'
findsubtitles/quazip/zip.h:216: error: expected initializer before
'zipCloseFileInZipRaw'
findsubtitles/quazip/zip.h:225: error: expected initializer before 'zipClose'
In file included from findsubtitles/quazip/quazip.h:40,
from findsubtitles/findsubtitleswindow.cpp:39:
findsubtitles/quazip/unzip.h:66: error: 'voidp' does not name a type
findsubtitles/quazip/unzip.h:82: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:83: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:84: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:85: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:86: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:87: error: 'uInt' does not name a type
findsubtitles/quazip/unzip.h:94: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:96: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:103: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:104: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:105: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:106: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:107: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:108: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:109: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:110: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:111: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:112: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:113: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:115: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:116: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:117: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:122: error: expected initializer before
'unzStringFileNameCompare'
findsubtitles/quazip/unzip.h:135: error: 'unzFile' does not name a type
findsubtitles/quazip/unzip.h:146: error: 'unzFile' does not name a type
findsubtitles/quazip/unzip.h:153: error: expected initializer before 'unzClose'
findsubtitles/quazip/unzip.h:160: error: expected initializer before
'unzGetGlobalInfo'
findsubtitles/quazip/unzip.h:168: error: expected initializer before
'unzGetGlobalComment'
findsubtitles/quazip/unzip.h:181: error: expected initializer before
'unzGoToFirstFile'
findsubtitles/quazip/unzip.h:187: error: expected initializer before
'unzGoToNextFile'
findsubtitles/quazip/unzip.h:194: error: expected initializer before
'unzLocateFile'
findsubtitles/quazip/unzip.h:212: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:213: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:216: error: expected initializer before
'unzGetFilePos'
findsubtitles/quazip/unzip.h:220: error: expected initializer before
'unzGoToFilePos'
findsubtitles/quazip/unzip.h:226: error: expected initializer before
'unzGetCurrentFileInfo'
findsubtitles/quazip/unzip.h:252: error: expected initializer before
'unzOpenCurrentFile'
findsubtitles/quazip/unzip.h:258: error: expected initializer before
'unzOpenCurrentFilePassword'
findsubtitles/quazip/unzip.h:266: error: expected initializer before
'unzOpenCurrentFile2'
findsubtitles/quazip/unzip.h:279: error: expected initializer before
'unzOpenCurrentFile3'
findsubtitles/quazip/unzip.h:294: error: expected initializer before
'unzCloseCurrentFile'
findsubtitles/quazip/unzip.h:300: error: expected initializer before
'unzReadCurrentFile'
findsubtitles/quazip/unzip.h:314: error: 'z_off_t' does not name a type
findsubtitles/quazip/unzip.h:319: error: expected initializer before 'unzeof'
findsubtitles/quazip/unzip.h:324: error: expected initializer before
'unzGetLocalExtrafield'
findsubtitles/quazip/unzip.h:343: error: 'uLong' does not name a type
findsubtitles/quazip/unzip.h:346: error: expected initializer before
'unzSetOffset'
In file included from findsubtitles/findsubtitleswindow.cpp:39:
findsubtitles/quazip/quazip.h:128: error: 'unzFile' does not name a type
findsubtitles/quazip/quazip.h:129: error: 'zipFile' does not name a type
findsubtitles/quazip/quazip.h:337: error: 'unzFile' does not name a type
findsubtitles/quazip/quazip.h:343: error: 'zipFile' does not name a type
In file included from findsubtitles/findsubtitleswindow.cpp:40:
findsubtitles/quazip/quazipfile.h:344: error: 'Z_DEFLATED' was not
declared in this scope
findsubtitles/quazip/quazipfile.h:344: error: 'Z_DEFAULT_COMPRESSION'
was not declared in this scope
findsubtitles/quazip/quazipfile.h:345: error: 'MAX_WBITS' was not
declared in this scope
findsubtitles/quazip/quazipfile.h:345: error: 'MAX_MEM_LEVEL' was not
declared in this scope
findsubtitles/quazip/quazipfile.h:345: error: 'Z_DEFAULT_STRATEGY' was
not declared in this scope
make[2]: *** [.obj/findsubtitleswindow.o] Error 1
make[2]: Leaving directory `/tmp/buildd/smplayer-0.6.7/src'
make[1]: *** [src/smplayer] Error 2
make[1]: Leaving directory `/tmp/buildd/smplayer-0.6.7'
make: *** [debian/stamp-makefile-build] Error 2
dpkg-buildpackage: failure: debian/rules build gave error exit status 2
<<<
Use pbuilder to test packages.
Once these are all fixed, feel free to reupload to mentors.d.n and
reply to this email.
Cheers,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: