[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: commons-math



On Sun Mar 15 20:30, Damien Raude-Morvan wrote:
> Dear mentors and Java maintainers,
> 
> I am looking for a sponsor for my package "commons-math".

Hi Damien, I'm looking at it now, I've got a couple of points,

firstly, libraries should not depend on runtimes (you depend on
openjdk-6-jre-headless | java2-runtime-headless), applications using
them should depend on appropriate runtimes.

Secondly, the 'other' licences you list are actually BSD licences, you
should probably cite them as such and just link to the one in
/usr/share/common-licences.

> This package is build using OpenJDK6 instead of GCJ because OpenJDK6 is really 
> faster doing test-suite (x10 factor).

Is it really faster if you build with openjdk? what about if you build
with default-jdk and run with gcj? If it is just the JRE which makes a
difference I think you should build with default-jdk and then just
document that people should run their apps against it with openjdk.

If it's just the length of time to run the test suite at build time...
I'm not sure. It's a significant proportion of the build time already,
does the test suite need to be run on every build?

It looks pretty good in general though, I'm happy to upload if you at
least fix the depends.

Matt

-- 
Matthew Johnson

Attachment: signature.asc
Description: Digital signature


Reply to: