Re: RFS: sqldeveloper-package
-----BEGIN PGP SIGNED MESSAGE-----
Daniel Moerner wrote:
> Hi, IANADD, but here are some comments.
> On Tue, Feb 3, 2009 at 7:28 PM, Lazarus Long <firstname.lastname@example.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> Dear mentors,
>> I am looking for a sponsor for my package "sqldeveloper-package".
> grep ITP debian/changelog reveals that there was no initial ITP filed;
> you need to file an intent to package even for native Debian packages.
> In fact, I would say that an ITP is even more important for native
> packages because if Debian is the upstream, so to speak, it is good
> for developers to hear about it on debian-devel.
You are right, I delayed filling the ITP until I got an acceptable
script so much I ended up forgetting to do it. Fixed: ITP #514124
> Since you are upstream, any reason why the manpage is in debian/
> instead of in the source?
Well, it was the place where dh_make had put the example manpages, so I
put it there also, but you are right, moved it to the top level
directory along with the README.
> In debian/rules, you are already using debhelper level 7 so there is
> no need to remove the stamps in the clean target--dh_clean does this
> for you. Similarly, you should use dh_prep instead of dh_clean -k.
> This shows up in lintian:
> W: sqldeveloper-package source: dh-clean-k-is-deprecated
Also automatically generated by dh_make. Corrected.
> I: sqldeveloper-package: copyright-with-old-dh-make-debian-copyright
> For such a simple package, you might want to use dh calls in
> debian/rules (man dh).
I looked this up and implemented it as you suggested, thank you very much.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----